Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2874263002:
Don't count modifiers-changed events as being user gestures. (Closed)
|
Created:
3 years, 7 months ago by Avi (use Gerrit) Modified:
3 years, 7 months ago CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, Navid Zolghadr, blink-reviews, blink-reviews-api_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDon't count modifiers-changed events as being user gestures.
BUG=709765
TEST=as in bug
Review-Url: https://codereview.chromium.org/2874263002
Cr-Commit-Position: refs/heads/master@{#472876}
Committed: https://chromium.googlesource.com/chromium/src/+/42fad93f54e4ee681975517e2831614b5dbade05
Patch Set 1 #
Messages
Total messages: 32 (19 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
avi@chromium.org changed reviewers: + dtapuska@chromium.org
Dave, PTAL.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
avi@chromium.org changed reviewers: + japhet@chromium.org
Nate, other Blink coverage to you.
On 2017/05/11 18:57:13, Avi (ping after 24h) wrote: > Nate, other Blink coverage to you. lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/05/11 19:12:04, dtapuska wrote: > On 2017/05/11 18:57:13, Avi (ping after 24h) wrote: > > Nate, other Blink coverage to you. > > lgtm Nate, ping.
lgtm
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495120522009270, "parent_rev":
"b6270d12412565789accd0aa7d37f11a86982fb1", "commit_rev":
"42fad93f54e4ee681975517e2831614b5dbade05"}
Message was sent while issue was closed.
Description was changed from ========== Don't count modifiers-changed events as being user gestures. BUG=709765 TEST=as in bug ========== to ========== Don't count modifiers-changed events as being user gestures. BUG=709765 TEST=as in bug Review-Url: https://codereview.chromium.org/2874263002 Cr-Commit-Position: refs/heads/master@{#472876} Committed: https://chromium.googlesource.com/chromium/src/+/42fad93f54e4ee681975517e2831... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/42fad93f54e4ee681975517e2831... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
