[mDns] Make DnsSdRegistry a leaky singleton

[mDns] Make DnsSdRegistry a leaky singleton

Make DnsSdRegistry a leaky singleton so that it can be used by both CastMediaSinkService and MDnsAPI.

BUG=687377
Review-Url: https://codereview.chromium.org/2874243003
Cr-Commit-Position: refs/heads/master@{#472201}
Committed: https://chromium.googlesource.com/chromium/src/+/7b350bad16013dbcd2d827072ae7827f0c36a005

[zhaobin, 2017-05-11 18:29:47]

zhaobin@chromium.org changed reviewers:
+ mfoltz@chromium.org

[mark a. foltz, 2017-05-11 23:22:24]

https://codereview.chromium.org/2874243003/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/mdns/mdns_api_unittest.cc (right):

https://codereview.chromium.org/2874243003/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/mdns/mdns_api_unittest.cc:112: auto* observer =
MdnsAPI implements the DnsSdObserver interface.  Is this cast necessary?

https://codereview.chromium.org/2874243003/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/discovery/mdns/dns_sd_registry.h (right):

https://codereview.chromium.org/2874243003/diff/1/chrome/browser/media/router...
chrome/browser/media/router/discovery/mdns/dns_sd_registry.h:26: class
MockDnsSdRegistry;
This is a sign this mock should live in c/b/media/router/discovery.  Is that
possible to fix in this patch?

[zhaobin, 2017-05-12 17:35:00]

https://codereview.chromium.org/2874243003/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/mdns/mdns_api_unittest.cc (right):

https://codereview.chromium.org/2874243003/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/mdns/mdns_api_unittest.cc:112: auto* observer =
On 2017/05/11 23:22:24, mark a. foltz wrote:
> MdnsAPI implements the DnsSdObserver interface.  Is this cast necessary?

Code removed.

https://codereview.chromium.org/2874243003/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/discovery/mdns/dns_sd_registry.h (right):

https://codereview.chromium.org/2874243003/diff/1/chrome/browser/media/router...
chrome/browser/media/router/discovery/mdns/dns_sd_registry.h:26: class
MockDnsSdRegistry;
On 2017/05/11 23:22:24, mark a. foltz wrote:
> This is a sign this mock should live in c/b/media/router/discovery.  Is that
> possible to fix in this patch?

Done.

[mark a. foltz, 2017-05-12 18:51:19]

LGTM with one nit

https://codereview.chromium.org/2874243003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/mdns/mdns_api.h (right):

https://codereview.chromium.org/2874243003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/mdns/mdns_api.h:16: #include
"chrome/browser/media/router/discovery/mdns/dns_sd_registry.h"
Can this #include be moved to the .cc?  You have a forward declaration for
DnsSdRegistry below.

[zhaobin, 2017-05-12 21:15:59]

https://codereview.chromium.org/2874243003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/mdns/mdns_api.h (right):

https://codereview.chromium.org/2874243003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/mdns/mdns_api.h:16: #include
"chrome/browser/media/router/discovery/mdns/dns_sd_registry.h"
On 2017/05/12 18:51:18, mark a. foltz wrote:
> Can this #include be moved to the .cc?  You have a forward declaration for
> DnsSdRegistry below.

Remove forward declaration. This #include is needed for inheritance:

: public media_router::DnsSdRegistry::DnsSdObserver

[zhaobin, 2017-05-16 17:52:15]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 17:53:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 19:56:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 19:56:13]

Dry run: This issue passed the CQ dry run.

[zhaobin, 2017-05-16 19:58:01]

The CQ bit was checked by zhaobin@chromium.org

[zhaobin, 2017-05-16 19:58:02]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org
Link to the patchset: https://codereview.chromium.org/2874243003/#ps40001
(title: "resolve code review comments from Mark")

[commit-bot: I haz the power, 2017-05-16 19:59:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 20:13:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494964681675920,
"parent_rev": "262cced60f936c9de24eaa94b6a96f2e1dcce7c0", "commit_rev":
"7b350bad16013dbcd2d827072ae7827f0c36a005"}

[commit-bot: I haz the power, 2017-05-16 20:13:17]

Description was changed from

==========
[mDns] Make DnsSdRegistry a leaky singleton

Make DnsSdRegistry a leaky singleton so that it can be used by both
CastMediaSinkService and MDnsAPI.

BUG=687377
==========

to

==========
[mDns] Make DnsSdRegistry a leaky singleton

Make DnsSdRegistry a leaky singleton so that it can be used by both
CastMediaSinkService and MDnsAPI.

BUG=687377

Review-Url: https://codereview.chromium.org/2874243003
Cr-Commit-Position: refs/heads/master@{#472201}
Committed:
https://chromium.googlesource.com/chromium/src/+/7b350bad16013dbcd2d827072ae7...
==========

[commit-bot: I haz the power, 2017-05-16 20:13:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7b350bad16013dbcd2d827072ae7...