Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2874213003: Update TestExpectations for failing LayoutTests. (Closed)

Created:
3 years, 7 months ago by apacible
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, blink-reviews, kozy
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update TestExpectations for failing LayoutTests. To unblock cq. See crbug for more details. BUG=720511 TBR=thakis@chromium.org Review-Url: https://codereview.chromium.org/2874213003 . Cr-Commit-Position: refs/heads/master@{#471003} Committed: https://chromium.googlesource.com/chromium/src/+/362df6f9c79116139df5f89867599d4e0f61bbb9

Patch Set 1 #

Patch Set 2 : Update to have all Failure Pass Timeout per thakis@'s comment. #

Patch Set 3 : Add virtual and non-virtual versions per kozyatinskiy@'s comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874213003/1
3 years, 7 months ago (2017-05-11 17:03:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874213003/20001
3 years, 7 months ago (2017-05-11 17:09:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874213003/40001
3 years, 7 months ago (2017-05-11 17:13:39 UTC) #15
apacible
3 years, 7 months ago (2017-05-11 17:52:21 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
362df6f9c79116139df5f89867599d4e0f61bbb9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698