[PageLoadMetrics] Ignore ad frames with no content

[PageLoadMetrics] Ignore ad frames with no content

Don't report metrics on ad frames with zero bytes.

There are a few other frame count metrics that would also have to be updated
to only report frames with more than zero bytes of content. That would require
a bit more memory per frame and the metrics appear to be of limited value, so
I'm removing them. We can add them back later if we feel that we need them.

BUG=720357
Review-Url: https://codereview.chromium.org/2874193003
Cr-Commit-Position: refs/heads/master@{#471793}
Committed: https://chromium.googlesource.com/chromium/src/+/bebe5e2ef075eb28dc5a90b3c7e3db1856711072

[jkarlin, 2017-05-11 13:20:31]

Patchset #1 (id:1) has been deleted

[jkarlin, 2017-05-11 13:20:35]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 13:21:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 14:29:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 14:29:57]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[jkarlin, 2017-05-11 14:32:20]

jkarlin@chromium.org changed reviewers:
+ bmcquade@chromium.org

[jkarlin, 2017-05-11 14:32:20]

bmcquade@ PTAL, thanks!

[Bryan McQuade, 2017-05-11 14:34:02]

lgtm

[jkarlin, 2017-05-11 14:36:55]

jkarlin@chromium.org changed reviewers:
+ isherman@chromium.org

[jkarlin, 2017-05-11 14:36:55]

Thanks!

isherman@ PTAL at histograms.xml. You'll be happy to see that I'm removing some
of the ads histograms.

[Ilya Sherman, 2017-05-11 20:14:53]

histograms.xml lgtm, thanks

[jkarlin, 2017-05-12 15:59:49]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 16:00:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 16:05:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 16:05:32]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jkarlin, 2017-05-15 15:13:57]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 15:14:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2017-05-15 16:19:26]

The CQ bit was unchecked by jkarlin@chromium.org

[jkarlin, 2017-05-15 16:19:27]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2017-05-15 16:19:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmcquade@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2874193003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-15 16:20:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 16:39:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494865167776260,
"parent_rev": "676fe3e7a5bddebfac81d2fde461e21d932d3994", "commit_rev":
"bebe5e2ef075eb28dc5a90b3c7e3db1856711072"}

[commit-bot: I haz the power, 2017-05-15 16:39:24]

Description was changed from

==========
[PageLoadMetrics] Ignore ad frames with no content

Don't report metrics on ad frames with zero bytes.

There are a few other frame count metrics that would also have to be updated
to only report frames with more than zero bytes of content. That would require
a bit more memory per frame and the metrics appear to be of limited value, so
I'm removing them. We can add them back later if we feel that we need them.

BUG=720357
==========

to

==========
[PageLoadMetrics] Ignore ad frames with no content

Don't report metrics on ad frames with zero bytes.

There are a few other frame count metrics that would also have to be updated
to only report frames with more than zero bytes of content. That would require
a bit more memory per frame and the metrics appear to be of limited value, so
I'm removing them. We can add them back later if we feel that we need them.

BUG=720357

Review-Url: https://codereview.chromium.org/2874193003
Cr-Commit-Position: refs/heads/master@{#471793}
Committed:
https://chromium.googlesource.com/chromium/src/+/bebe5e2ef075eb28dc5a90b3c7e3...
==========

[commit-bot: I haz the power, 2017-05-15 16:39:25]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bebe5e2ef075eb28dc5a90b3c7e3...