Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2874183002: [Android] Fix Text selection with Stylus button pressed from Android M (Closed)

Created:
3 years, 7 months ago by MaheshMachavolu
Modified:
3 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix Text selection with Stylus button pressed from Android M Stylus text selection with stylus button pressed does not work from Android M as the button state for stylus event has been changed. Add code to support new button state - MotionEvent::BUTTON_STYLUS_PRIMARY. BUG=721304 Review-Url: https://codereview.chromium.org/2874183002 Cr-Commit-Position: refs/heads/master@{#474141} Committed: https://chromium.googlesource.com/chromium/src/+/529c2f2c71f13edbfd34df3c8c1129f39edaeb3f

Patch Set 1 #

Patch Set 2 : Add unit test #

Patch Set 3 : Add inline comments as suggested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -4 lines) Patch
M content/browser/renderer_host/input/stylus_text_selector.cc View 1 2 2 chunks +9 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/stylus_text_selector_unittest.cc View 1 2 4 chunks +170 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
AKVT
Looks good to me! It'd be better if we can cover this scenario in stylus_text_selector_unittest.cc
3 years, 7 months ago (2017-05-11 11:29:56 UTC) #2
MaheshMachavolu
On 2017/05/11 11:29:56, AKVT wrote: > Looks good to me! > > It'd be better ...
3 years, 7 months ago (2017-05-12 11:56:41 UTC) #3
MaheshMachavolu
On 2017/05/12 11:56:41, MaheshMachavolu wrote: > On 2017/05/11 11:29:56, AKVT wrote: > > Looks good ...
3 years, 7 months ago (2017-05-22 12:05:11 UTC) #6
aelias_OOO_until_Jul13
lgtm, but please add some comments in the code and unit tests explaining that this ...
3 years, 7 months ago (2017-05-22 20:20:54 UTC) #9
MaheshMachavolu
On 2017/05/22 20:20:54, aelias wrote: > lgtm, but please add some comments in the code ...
3 years, 7 months ago (2017-05-23 07:01:34 UTC) #12
aelias_OOO_until_Jul13
Still lgtm
3 years, 7 months ago (2017-05-23 18:20:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874183002/40001
3 years, 7 months ago (2017-05-24 02:55:20 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 03:05:07 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/529c2f2c71f13edbfd34df3c8c11...

Powered by Google App Engine
This is Rietveld 408576698