Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2874183002:
[Android] Fix Text selection with Stylus button pressed from Android M (Closed)
|
Created:
3 years, 7 months ago by MaheshMachavolu Modified:
3 years, 7 months ago CC:
chromium-reviews, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, jam Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Android] Fix Text selection with Stylus button pressed from Android M
Stylus text selection with stylus button pressed does not work from
Android M as the button state for stylus event has been changed. Add
code to support new button state - MotionEvent::BUTTON_STYLUS_PRIMARY.
BUG=721304
Review-Url: https://codereview.chromium.org/2874183002
Cr-Commit-Position: refs/heads/master@{#474141}
Committed: https://chromium.googlesource.com/chromium/src/+/529c2f2c71f13edbfd34df3c8c1129f39edaeb3f
Patch Set 1 #Patch Set 2 : Add unit test #Patch Set 3 : Add inline comments as suggested #
Messages
Total messages: 24 (16 generated)
ajith.v@samsung.com changed reviewers: + ajith.v@samsung.com
Looks good to me! It'd be better if we can cover this scenario in stylus_text_selector_unittest.cc
On 2017/05/11 11:29:56, AKVT wrote: > Looks good to me! > > It'd be better if we can cover this scenario in stylus_text_selector_unittest.cc I'm working on the tests. Will upload after it is done.
Description was changed from ========== Fix Stylus selection with stylus button pressed from M os onwards Stylus selection with stylus button pressed does not work from Android M OS onwards as the event for stylus button has been changed from M. Add support to new event- MotionEvent::BUTTON_STYLUS_PRIMARY. BUG=721304 ========== to ========== Fix Stylus selection with stylus button pressed from M os onwards Stylus selection with stylus button pressed does not work from Android M OS onwards as the event for stylus button has been changed from M. Add support to new event- MotionEvent::BUTTON_STYLUS_PRIMARY. BUG=721304 ==========
mahesh.ma@samsung.com changed reviewers: + aelias@chromium.org, dtapuska@chromium.org
On 2017/05/12 11:56:41, MaheshMachavolu wrote: > On 2017/05/11 11:29:56, AKVT wrote: > > Looks good to me! > > > > It'd be better if we can cover this scenario in > stylus_text_selector_unittest.cc > > I'm working on the tests. Will upload after it is done. I have uploaded unit tests. Please review.
The CQ bit was checked by aelias@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm, but please add some comments in the code and unit tests explaining that this changed in Android M.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/05/22 20:20:54, aelias wrote: > lgtm, but please add some comments in the code and unit tests explaining that > this changed in Android M. Inline comments have been added in code and unit tests. Please review again.
Description was changed from ========== Fix Stylus selection with stylus button pressed from M os onwards Stylus selection with stylus button pressed does not work from Android M OS onwards as the event for stylus button has been changed from M. Add support to new event- MotionEvent::BUTTON_STYLUS_PRIMARY. BUG=721304 ========== to ========== Fix Stylus Text selection with stylus button pressed from Android M Stylus text selection with stylus button pressed does not work from Android M as the button state for stylus event has been changed. Add code to support new button state - MotionEvent::BUTTON_STYLUS_PRIMARY. BUG=721304 ==========
Description was changed from ========== Fix Stylus Text selection with stylus button pressed from Android M Stylus text selection with stylus button pressed does not work from Android M as the button state for stylus event has been changed. Add code to support new button state - MotionEvent::BUTTON_STYLUS_PRIMARY. BUG=721304 ========== to ========== [Android] Fix Text selection with Stylus button pressed from Android M Stylus text selection with stylus button pressed does not work from Android M as the button state for stylus event has been changed. Add code to support new button state - MotionEvent::BUTTON_STYLUS_PRIMARY. BUG=721304 ==========
Still lgtm
The CQ bit was checked by aelias@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mahesh.ma@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495594432903730,
"parent_rev": "4bb59edb9d55aa56f4e79236e86f081b92c686ef", "commit_rev":
"529c2f2c71f13edbfd34df3c8c1129f39edaeb3f"}
Message was sent while issue was closed.
Description was changed from ========== [Android] Fix Text selection with Stylus button pressed from Android M Stylus text selection with stylus button pressed does not work from Android M as the button state for stylus event has been changed. Add code to support new button state - MotionEvent::BUTTON_STYLUS_PRIMARY. BUG=721304 ========== to ========== [Android] Fix Text selection with Stylus button pressed from Android M Stylus text selection with stylus button pressed does not work from Android M as the button state for stylus event has been changed. Add code to support new button state - MotionEvent::BUTTON_STYLUS_PRIMARY. BUG=721304 Review-Url: https://codereview.chromium.org/2874183002 Cr-Commit-Position: refs/heads/master@{#474141} Committed: https://chromium.googlesource.com/chromium/src/+/529c2f2c71f13edbfd34df3c8c11... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/529c2f2c71f13edbfd34df3c8c11... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
