Retreive screenshots captured by tests from test devices.

Retreive screenshots captured by tests from test devices.

We are creating some new instrumentationt tests which capture
screenshots as they run. Clear the test device's screenshot
directory before they run.

Add a --ui-screenshot-dir to test_runner.py. If specified then,
once the tests have been run, the screenshots are copied to
the given directory on the host.

BUG=721289
Review-Url: https://codereview.chromium.org/2874173002
Cr-Commit-Position: refs/heads/master@{#474231}
Committed: https://chromium.googlesource.com/chromium/src/+/b9e451ab1f65fec40a11146a868aa07565a74390

[aberent, 2017-05-11 10:12:15]

aberent@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2017-05-11 18:10:48]

jbudorick@chromium.org changed reviewers:
+ mikecase@chromium.org

[aberent, 2017-05-19 12:15:48]

Ping!

It is now over a week since I requested a review.

[wrong jbudorick, 2017-05-19 13:25:37]

On 2017/05/19 12:15:48, aberent wrote:
> Ping!
> 
> It is now over a week since I requested a review.

Sorry about the delay here. I added Case because I think he's a better reviewer
for this given the related work he's doing, but I failed to adequately
communicate that. We'll review this today.

[mikecase (-- gone --), 2017-05-19 15:46:43]

https://codereview.chromium.org/2874173002/diff/40001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_instrumentation_test_run.py
(right):

https://codereview.chromium.org/2874173002/diff/40001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:219:
@trace_event.traced
Maybe add this to pull_ui_screen_captures as well if you are interested in
tracing.
pulling will probably be the thing to take more time.

https://codereview.chromium.org/2874173002/diff/40001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:224:
'chromium_tests_root', 'UiCapture')
nit: for indentation, I would align 'chr... with above dev...

https://codereview.chromium.org/2874173002/diff/40001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:262:
'chromium_tests_root', 'UiCapture')
I'm guessing this will have to be kept in sync with some hard-coded path in Java
code? Might be nicer to pass path in thru Instrumentation argument or via
command-line flag.

https://codereview.chromium.org/2874173002/diff/40001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:269:
dev.PullFile(posixpath.join(capture_dir, file_name), target_path)
Even though the name doesn't make it seem like it, PullFile should pull the
entire directory if you just pass the directory to it. No need to iterate thru
the files (99% sure)

https://codereview.chromium.org/2874173002/diff/40001/build/android/test_runn...
File build/android/test_runner.py (right):

https://codereview.chromium.org/2874173002/diff/40001/build/android/test_runn...
build/android/test_runner.py:432: parser.add_argument(
This looks like it was accidentally re-added

[aberent, 2017-05-22 18:03:20]

https://codereview.chromium.org/2874173002/diff/40001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_instrumentation_test_run.py
(right):

https://codereview.chromium.org/2874173002/diff/40001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:219:
@trace_event.traced
On 2017/05/19 15:46:43, mikecase wrote:
> Maybe add this to pull_ui_screen_captures as well if you are interested in
> tracing.
> pulling will probably be the thing to take more time.

Done.

https://codereview.chromium.org/2874173002/diff/40001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:224:
'chromium_tests_root', 'UiCapture')
On 2017/05/19 15:46:43, mikecase wrote:
> nit: for indentation, I would align 'chr... with above dev...

Done.

https://codereview.chromium.org/2874173002/diff/40001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:262:
'chromium_tests_root', 'UiCapture')
On 2017/05/19 15:46:43, mikecase wrote:
> I'm guessing this will have to be kept in sync with some hard-coded path in
Java
> code? Might be nicer to pass path in thru Instrumentation argument or via
> command-line flag.

Done.

https://codereview.chromium.org/2874173002/diff/40001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:269:
dev.PullFile(posixpath.join(capture_dir, file_name), target_path)
On 2017/05/19 15:46:43, mikecase wrote:
> Even though the name doesn't make it seem like it, PullFile should pull the
> entire directory if you just pass the directory to it. No need to iterate thru
> the files (99% sure)

So I thought originally. The problem is that PullFile behaves like Linux cp or
mv. If the target directory exists then it creates a subdirectory with the name
of the source in the target. I could delete the target directory, but that would
delete any results of previous runs of possibly different test. If your run

adb pull /a/b /c/d

then, if d exists you will end up with /c/d/b whereas if it doesn't it will
create d and copy the contents of b into d.

https://codereview.chromium.org/2874173002/diff/40001/build/android/test_runn...
File build/android/test_runner.py (right):

https://codereview.chromium.org/2874173002/diff/40001/build/android/test_runn...
build/android/test_runner.py:432: parser.add_argument(
On 2017/05/19 15:46:43, mikecase wrote:
> This looks like it was accidentally re-added

Done.

[aberent, 2017-05-23 17:03:15]

The CQ bit was checked by aberent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 17:04:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 18:08:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 18:08:52]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[mikecase (-- gone --), 2017-05-23 18:16:17]

lgtm

[aberent, 2017-05-24 08:58:17]

The CQ bit was checked by aberent@chromium.org

[commit-bot: I haz the power, 2017-05-24 08:58:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 09:54:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495616297678900,
"parent_rev": "a590e1184af37fc63ff311976de04dda8d48eb02", "commit_rev":
"b9e451ab1f65fec40a11146a868aa07565a74390"}

[commit-bot: I haz the power, 2017-05-24 09:54:41]

Description was changed from

==========
Retreive screenshots captured by tests from test devices.

We are creating some new instrumentationt tests which capture
screenshots as they run. Clear the test device's screenshot
directory before they run.

Add a --ui-screenshot-dir to test_runner.py. If specified then,
once the tests have been run, the screenshots are copied to
the given directory on the host.

BUG=721289
==========

to

==========
Retreive screenshots captured by tests from test devices.

We are creating some new instrumentationt tests which capture
screenshots as they run. Clear the test device's screenshot
directory before they run.

Add a --ui-screenshot-dir to test_runner.py. If specified then,
once the tests have been run, the screenshots are copied to
the given directory on the host.

BUG=721289

Review-Url: https://codereview.chromium.org/2874173002
Cr-Commit-Position: refs/heads/master@{#474231}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9e451ab1f65fec40a11146a868a...
==========

[commit-bot: I haz the power, 2017-05-24 09:54:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b9e451ab1f65fec40a11146a868a...