Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2874153004: Revert change to BroserWindowCocoa::PreHandleKeyboardEvent in 2824803004 (Closed)

Created:
3 years, 7 months ago by Hzj_jie
Modified:
3 years, 7 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert change to BroserWindowCocoa::PreHandleKeyboardEvent in 2824803004 BUG=721384 Review-Url: https://codereview.chromium.org/2874153004 Cr-Commit-Position: refs/heads/master@{#471357} Committed: https://chromium.googlesource.com/chromium/src/+/fc91a3995bfd7cf39ce78b3b7d6fe69feadb9f34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Hzj_jie
Since the original change is questionable, I think a quick revert would be a safe ...
3 years, 7 months ago (2017-05-11 20:57:34 UTC) #5
dtapuska
On 2017/05/11 20:57:34, Hzj_jie wrote: > Since the original change is questionable, I think a ...
3 years, 7 months ago (2017-05-12 13:13:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874153004/1
3 years, 7 months ago (2017-05-12 16:51:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/435480)
3 years, 7 months ago (2017-05-12 17:01:22 UTC) #12
Hzj_jie
Avi, would you mind to LGTM this change to unblock submitting?
3 years, 7 months ago (2017-05-12 17:07:19 UTC) #14
Avi (use Gerrit)
LGTM
3 years, 7 months ago (2017-05-12 17:11:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874153004/1
3 years, 7 months ago (2017-05-12 17:13:18 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 17:47:59 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc91a3995bfd7cf39ce78b3b7d6f...

Powered by Google App Engine
This is Rietveld 408576698