|
|
Chromium Code Reviews
DescriptionRevert change to BroserWindowCocoa::PreHandleKeyboardEvent in 2824803004
BUG=721384
Review-Url: https://codereview.chromium.org/2874153004
Cr-Commit-Position: refs/heads/master@{#471357}
Committed: https://chromium.googlesource.com/chromium/src/+/fc91a3995bfd7cf39ce78b3b7d6fe69feadb9f34
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Description was changed from ========== Revert change to BroserWindowCocoa::PreHandleKeyboardEvent in 2824803004 BUG=721384 ========== to ========== Revert change to BroserWindowCocoa::PreHandleKeyboardEvent in 2824803004 BUG=721384 ==========
zijiehe@chromium.org changed reviewers: + dtapuska@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Since the original change is questionable, I think a quick revert would be a safe choice. We can discuss the detail later to unblock / resolve any potential changes or failures.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/05/11 20:57:34, Hzj_jie wrote: > Since the original change is questionable, I think a quick revert would be a > safe choice. We can discuss the detail later to unblock / resolve any potential > changes or failures. lgtm
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
zijiehe@chromium.org changed reviewers: + avi@chromium.org
Avi, would you mind to LGTM this change to unblock submitting?
LGTM
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494609125236980, "parent_rev":
"03ce267472a3f16830796d5bd04d79371d61afaf", "commit_rev":
"fc91a3995bfd7cf39ce78b3b7d6fe69feadb9f34"}
Message was sent while issue was closed.
Description was changed from ========== Revert change to BroserWindowCocoa::PreHandleKeyboardEvent in 2824803004 BUG=721384 ========== to ========== Revert change to BroserWindowCocoa::PreHandleKeyboardEvent in 2824803004 BUG=721384 Review-Url: https://codereview.chromium.org/2874153004 Cr-Commit-Position: refs/heads/master@{#471357} Committed: https://chromium.googlesource.com/chromium/src/+/fc91a3995bfd7cf39ce78b3b7d6f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fc91a3995bfd7cf39ce78b3b7d6f... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
