Apply filter mutation to effect tree directly for SPv2.

Apply filter mutation to effect tree directly for SPv2.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2874083002
Cr-Commit-Position: refs/heads/master@{#471180}
Committed: https://chromium.googlesource.com/chromium/src/+/8fceabf03ed354db18981910bdbfb5a9ee31e59f

[wkorman, 2017-05-10 21:59:47]

Description was changed from

==========
Apply filter mutation to effect tree directly for SPv2.

BUG=709137
==========

to

==========
Apply filter mutation to effect tree directly for SPv2.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[wkorman, 2017-05-10 22:00:00]

wkorman@chromium.org changed reviewers:
+ chrishtr@chromium.org

[wkorman, 2017-05-10 22:00:39]

Description was changed from

==========
Apply filter mutation to effect tree directly for SPv2.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Apply filter mutation to effect tree directly for SPv2.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[wkorman, 2017-05-10 22:01:03]

Description was changed from

==========
Apply filter mutation to effect tree directly for SPv2.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Apply filter mutation to effect tree directly for SPv2.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[wkorman, 2017-05-10 22:01:07]

The CQ bit was checked by wkorman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 22:03:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wkorman, 2017-05-10 22:24:25]

https://codereview.chromium.org/2874083002/diff/1/cc/trees/layer_tree_host.cc
File cc/trees/layer_tree_host.cc (left):

https://codereview.chromium.org/2874083002/diff/1/cc/trees/layer_tree_host.cc...
cc/trees/layer_tree_host.cc:1263: void
LayerTreeHost::SetElementFilterMutated(ElementId element_id,
Commenting out the entire implementation of this method doesn't appear to cause
any tests to fail in cc_unittests, webkit_unit_tests, or
blink_platform_unittests.

It also doesn't appear to cause any layout tests to fail under:

% ./third_party/WebKit/Tools/Scripts/run-webkit-tests animations transitions
compositing virtual/threaded/animations virtual/threaded/transitions
virtual/threaded/compositing

Am adding NOTREACHED() and will look at writing test case that should execute
this code path.

[chrishtr, 2017-05-10 22:40:10]

Looks great modulo a test!

[wkorman, 2017-05-11 00:29:43]

Added unit test.

[chrishtr, 2017-05-11 01:17:59]

lgtm

[wkorman, 2017-05-11 01:27:56]

wkorman@chromium.org changed reviewers:
+ enne@chromium.org

[wkorman, 2017-05-11 01:27:56]

+enne for OWNERS

[wkorman, 2017-05-11 22:41:33]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2017-05-11 22:41:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2874083002/#ps40001
(title: "Sync to head.")

[commit-bot: I haz the power, 2017-05-11 22:42:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 02:00:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494542493742700,
"parent_rev": "a08630cb7937d370481f2068f7d93779f437f191", "commit_rev":
"f3ba1f2a0c3114629ca067c4ea149b893ff66ea0"}

[commit-bot: I haz the power, 2017-05-12 02:00:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494542493742700,
"parent_rev": "080d5b71bd1a96567a535f3d6607906c479d8625", "commit_rev":
"8fceabf03ed354db18981910bdbfb5a9ee31e59f"}

[commit-bot: I haz the power, 2017-05-12 02:00:56]

Description was changed from

==========
Apply filter mutation to effect tree directly for SPv2.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Apply filter mutation to effect tree directly for SPv2.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2874083002
Cr-Commit-Position: refs/heads/master@{#471180}
Committed:
https://chromium.googlesource.com/chromium/src/+/8fceabf03ed354db18981910bdbf...
==========

[commit-bot: I haz the power, 2017-05-12 02:00:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8fceabf03ed354db18981910bdbf...