Add layout tests for ImageLoader::UpdateFromElement(kUpdateForcedReload)

third_party/WebKit/Source/core/testing/Internals.cpp

Index: third_party/WebKit/Source/core/testing/Internals.cpp
diff --git a/third_party/WebKit/Source/core/testing/Internals.cpp b/third_party/WebKit/Source/core/testing/Internals.cpp
index e28fde49ab24ff702ed71f5f4734960e3c902cff..86bdb0b7cb5495526658bbfd9ee1d91cab7e6129 100644
--- a/third_party/WebKit/Source/core/testing/Internals.cpp
+++ b/third_party/WebKit/Source/core/testing/Internals.cpp
@@ -2781,6 +2781,12 @@ String Internals::getImageSourceURL(Element* element) {
   return element->ImageSourceURL();
 }
 
+void Internals::forceImageReload(Element* element) {
+  DCHECK(element);
+  DCHECK(isHTMLImageElement(*element));

[kouhei (in TOK), 2017/05/11 16:50:52]

replace DCHECKs w/ if (element && isHTMLImageElement(*element))

[hiroshige, 2017/05/11 17:11:44]

Because this is Internals, and for debugging/testing purpose I expect crashing
by DCHECK() is better than silently skipping non-HTMLImageElement.

[kouhei (in TOK), 2017/05/11 17:30:14]

Other Intenals API throws an exception or silently fails on invalid arg, so I
expect forceImageReload to follow it too.

[hiroshige, 2017/05/11 18:12:15]

Sounds good. Done.

+  toHTMLImageElement(*element).ForceReload();
+}
+
 String Internals::selectMenuListText(HTMLSelectElement* select) {
   DCHECK(select);
   LayoutObject* layout_object = select->GetLayoutObject();