Add layout tests for ImageLoader::UpdateFromElement(kUpdateForcedReload)

third_party/WebKit/Source/core/testing/Internals.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 2763 matching lines @@
 String Internals::markerTextForListItem(Element* element) {
   DCHECK(element);
   return blink::MarkerTextForListItem(element);
 }
 
 String Internals::getImageSourceURL(Element* element) {
   DCHECK(element);
   return element->ImageSourceURL();
 }
 
+void Internals::forceImageReload(Element* element) {
+  DCHECK(element);
+  DCHECK(isHTMLImageElement(*element));

[kouhei (in TOK), 2017/05/11 16:50:52]

replace DCHECKs w/ if (element && isHTMLImageElement(*element))

[hiroshige, 2017/05/11 17:11:44]

Because this is Internals, and for debugging/testing purpose I expect crashing
by DCHECK() is better than silently skipping non-HTMLImageElement.

[kouhei (in TOK), 2017/05/11 17:30:14]

Other Intenals API throws an exception or silently fails on invalid arg, so I
expect forceImageReload to follow it too.

[hiroshige, 2017/05/11 18:12:15]

Sounds good. Done.

+  toHTMLImageElement(*element).ForceReload();
+}
+
 String Internals::selectMenuListText(HTMLSelectElement* select) {
   DCHECK(select);
   LayoutObject* layout_object = select->GetLayoutObject();
   if (!layout_object || !layout_object->IsMenuList())
     return String();
 
   LayoutMenuListItem menu_list_item =
       LayoutMenuListItem(ToLayoutMenuList(layout_object));
   return menu_list_item.GetText();
 }
@@ skipping 477 matching lines @@
 
 void Internals::crash() {
   CHECK(false) << "Intentional crash";
 }
 
 void Internals::setIsLowEndDevice(bool is_low_end_device) {
   MemoryCoordinator::SetIsLowEndDeviceForTesting(is_low_end_device);
 }
 
 }  // namespace blink