Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2874063002: enable video blit color accuracy by default (Closed)

Created:
3 years, 7 months ago by hubbe
Modified:
3 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

enable video blit color accuracy by default BUG=671344, 760132 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://chromiumcodereview.appspot.com/2874063002 Cr-Commit-Position: refs/heads/master@{#499721} Committed: https://chromium.googlesource.com/chromium/src/+/811b6eabf491a296a8bd73eba1d4cb0a9c173dc4

Patch Set 1 #

Patch Set 2 : bypass gpu pixel tests #

Patch Set 3 : disable test on all platforms #

Total comments: 2

Patch Set 4 : test name fix #

Patch Set 5 : bypass tests properly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_test_pages.py View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M media/base/media_switches.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 110 (70 generated)
hubbe
3 years, 7 months ago (2017-05-10 22:10:28 UTC) #6
jbauman
lgtm
3 years, 7 months ago (2017-05-10 22:19:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 7 months ago (2017-05-10 22:25:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450889)
3 years, 7 months ago (2017-05-10 23:33:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 7 months ago (2017-05-11 18:10:03 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/452074)
3 years, 7 months ago (2017-05-11 20:09:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 7 months ago (2017-05-11 20:25:59 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/442365)
3 years, 7 months ago (2017-05-12 00:55:18 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 4 months ago (2017-07-28 22:16:01 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/501117)
3 years, 4 months ago (2017-07-29 05:12:25 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 4 months ago (2017-07-29 16:23:45 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/501336)
3 years, 4 months ago (2017-07-29 20:47:46 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 4 months ago (2017-08-11 16:49:03 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/360766)
3 years, 4 months ago (2017-08-11 18:36:47 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 4 months ago (2017-08-11 18:59:43 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/360965)
3 years, 4 months ago (2017-08-11 20:58:14 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 4 months ago (2017-08-11 21:04:43 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/361087)
3 years, 4 months ago (2017-08-11 22:35:36 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 4 months ago (2017-08-11 22:40:34 UTC) #48
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/510968)
3 years, 4 months ago (2017-08-12 04:14:02 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 4 months ago (2017-08-22 18:13:17 UTC) #52
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/517580)
3 years, 4 months ago (2017-08-22 22:54:40 UTC) #54
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 4 months ago (2017-08-23 20:29:45 UTC) #56
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/369765)
3 years, 4 months ago (2017-08-23 21:57:46 UTC) #58
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 4 months ago (2017-08-23 22:02:33 UTC) #60
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/518914)
3 years, 4 months ago (2017-08-24 03:56:34 UTC) #62
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 4 months ago (2017-08-24 17:02:46 UTC) #64
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/519578)
3 years, 4 months ago (2017-08-24 21:45:59 UTC) #66
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 3 months ago (2017-08-29 17:24:49 UTC) #68
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/522353)
3 years, 3 months ago (2017-08-29 22:27:52 UTC) #70
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/1
3 years, 3 months ago (2017-08-30 21:13:27 UTC) #72
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/523416)
3 years, 3 months ago (2017-08-31 02:30:10 UTC) #74
ynovikov
https://codereview.chromium.org/2874063002/diff/40001/content/test/gpu/gpu_tests/pixel_expectations.py File content/test/gpu/gpu_tests/pixel_expectations.py (right): https://codereview.chromium.org/2874063002/diff/40001/content/test/gpu/gpu_tests/pixel_expectations.py#newcode64 content/test/gpu/gpu_tests/pixel_expectations.py:64: self.Fail('PixelIntegrationTest.Pixel_Video_MP4', bug=760132) Remove "PixelIntegrationTest.", this should fix it.
3 years, 3 months ago (2017-09-05 14:40:51 UTC) #91
hubbe
https://codereview.chromium.org/2874063002/diff/40001/content/test/gpu/gpu_tests/pixel_expectations.py File content/test/gpu/gpu_tests/pixel_expectations.py (right): https://codereview.chromium.org/2874063002/diff/40001/content/test/gpu/gpu_tests/pixel_expectations.py#newcode64 content/test/gpu/gpu_tests/pixel_expectations.py:64: self.Fail('PixelIntegrationTest.Pixel_Video_MP4', bug=760132) On 2017/09/05 14:40:51, ynovikov wrote: > Remove ...
3 years, 3 months ago (2017-09-05 17:57:48 UTC) #94
hubbe
added overrides VP9 tests as well PTAL
3 years, 3 months ago (2017-09-05 18:05:18 UTC) #97
hubbe
Trying zmo for gpu test changes.
3 years, 3 months ago (2017-09-05 18:23:05 UTC) #100
Zhenyao Mo
LGTM Please remember to remove the "fail" entries when the expected images are updated
3 years, 3 months ago (2017-09-05 18:30:11 UTC) #102
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874063002/80001
3 years, 3 months ago (2017-09-05 18:31:42 UTC) #106
Ken Russell (switch to Gerrit)
lgtm
3 years, 3 months ago (2017-09-05 19:52:15 UTC) #107
commit-bot: I haz the power
3 years, 3 months ago (2017-09-05 20:01:34 UTC) #110
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/811b6eabf491a296a8bd73eba1d4...

Powered by Google App Engine
This is Rietveld 408576698