Remove obsolete repaint benchmarks.

Remove obsolete repaint benchmarks.

BUG=717538, 715704
Review-Url: https://codereview.chromium.org/2874043003
Cr-Commit-Position: refs/heads/master@{#471057}
Committed: https://chromium.googlesource.com/chromium/src/+/9ac1e972f92e44597cf8c9a0473fa2fc7f50655e

[wkorman, 2017-05-11 02:51:34]

wkorman@chromium.org changed reviewers:
+ nednguyen@google.com, pdr@chromium.org, vmpstr@chromium.org

[wkorman, 2017-05-11 02:51:35]

Not sure whether there is code in cc/Blink that we can remove. Will look
separately or if folks know of something input welcome on bug.

[wkorman, 2017-05-11 02:51:44]

Description was changed from

==========
Remove obsolete repaint benchmarks.

BUG=717538
==========

to

==========
Remove obsolete repaint benchmarks.

BUG=717538,715704
==========

[nednguyen, 2017-05-11 10:23:43]

https://codereview.chromium.org/2874043003/diff/40001/tools/perf/benchmarks/r...
File tools/perf/benchmarks/repaint.py (left):

https://codereview.chromium.org/2874043003/diff/40001/tools/perf/benchmarks/r...
tools/perf/benchmarks/repaint.py:81: class RepaintCT(_Repaint):
We want to keep this or move it to tools/perf/contrib/ directory, I think.

[nednguyen, 2017-05-11 14:18:35]

On 2017/05/11 10:23:43, nednguyen wrote:
>
https://codereview.chromium.org/2874043003/diff/40001/tools/perf/benchmarks/r...
> File tools/perf/benchmarks/repaint.py (left):
> 
>
https://codereview.chromium.org/2874043003/diff/40001/tools/perf/benchmarks/r...
> tools/perf/benchmarks/repaint.py:81: class RepaintCT(_Repaint):
> We want to keep this or move it to tools/perf/contrib/ directory, I think.

"keep and move", sorry :p

[wkorman, 2017-05-11 16:21:27]

https://codereview.chromium.org/2874043003/diff/40001/tools/perf/benchmarks/r...
File tools/perf/benchmarks/repaint.py (left):

https://codereview.chromium.org/2874043003/diff/40001/tools/perf/benchmarks/r...
tools/perf/benchmarks/repaint.py:81: class RepaintCT(_Repaint):
On 2017/05/11 10:23:43, nednguyen wrote:
> We want to keep this or move it to tools/perf/contrib/ directory, I think.

OK, yeah, I had figured it's disabled anyway so we could remove it and restore
in whatever form is correct for http://crbug.com/715704, but happy to leave it.

I went to move it but that has ramifications for the unit tests:

benchmarks.ct_benchmarks_unittest
benchmarks.benchmark_smoke_unittest

which seem best addressed by whoever does the other work on above bug, so I am
just going to leave this part.

[nednguyen, 2017-05-11 16:29:51]

lgtm

https://codereview.chromium.org/2874043003/diff/50006/tools/perf/benchmarks/r...
File tools/perf/benchmarks/repaint.py (right):

https://codereview.chromium.org/2874043003/diff/50006/tools/perf/benchmarks/r...
tools/perf/benchmarks/repaint.py:16: class
_Repaint(perf_benchmark.PerfBenchmark):
nits: this can be merged into RepaintCT as it's the only inherit benchmark now.

[wkorman, 2017-05-11 17:52:05]

https://codereview.chromium.org/2874043003/diff/50006/tools/perf/benchmarks/r...
File tools/perf/benchmarks/repaint.py (right):

https://codereview.chromium.org/2874043003/diff/50006/tools/perf/benchmarks/r...
tools/perf/benchmarks/repaint.py:16: class
_Repaint(perf_benchmark.PerfBenchmark):
On 2017/05/11 16:29:51, nednguyen wrote:
> nits: this can be merged into RepaintCT as it's the only inherit benchmark
now.

Done, which also means we have no remaining use of key_mobile_sites_repaint page
set, so I've removed that .py and .json file.

[wkorman, 2017-05-11 17:52:15]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2017-05-11 17:52:15]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2874043003/#ps70001
(title: "Cleanup from feedback.")

[commit-bot: I haz the power, 2017-05-11 17:53:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 19:05:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 19:05:50]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[nednguyen, 2017-05-11 19:11:03]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2017-05-11 19:11:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 20:29:33]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1494529863028230,
"parent_rev": "e41b5ce8a877875575ad0c370bd4bdc8593113b2", "commit_rev":
"9ac1e972f92e44597cf8c9a0473fa2fc7f50655e"}

[commit-bot: I haz the power, 2017-05-11 20:29:45]

Description was changed from

==========
Remove obsolete repaint benchmarks.

BUG=717538,715704
==========

to

==========
Remove obsolete repaint benchmarks.

BUG=717538,715704

Review-Url: https://codereview.chromium.org/2874043003
Cr-Commit-Position: refs/heads/master@{#471057}
Committed:
https://chromium.googlesource.com/chromium/src/+/9ac1e972f92e44597cf8c9a0473f...
==========

[commit-bot: I haz the power, 2017-05-11 20:29:46]

Committed patchset #5 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/9ac1e972f92e44597cf8c9a0473f...