Update media::BindToCurrentLoop to support base::OnceCallback

Update media::BindToCurrentLoop to support base::OnceCallback

After this CL, media::BindToCurrentLoop can take OnceCallback in addition
to RepeatingCallback, and then it returns the same type of callback object,
that relays its invocation to the target thread.

BUG=714018
Review-Url: https://codereview.chromium.org/2874003002
Cr-Commit-Position: refs/heads/master@{#471285}
Committed: https://chromium.googlesource.com/chromium/src/+/73c8ac7b44f40f19d829a04c069425613eebe34e

[tzik, 2017-05-10 13:06:18]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 13:06:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Max Morin, 2017-05-10 13:24:33]

I like this CL. The BindToCurrentLoop function still needs to be copied though,
right?

[commit-bot: I haz the power, 2017-05-10 14:58:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 14:58:25]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tzik, 2017-05-11 05:08:29]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 05:09:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-05-11 07:15:48]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 07:16:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-05-11 07:28:32]

Description was changed from

==========
OnceCallback support of BindToCurrentLoop
==========

to

==========
Update media::BindToCurrentLoop to support base::OnceCallback

123456789012345678901234567890123456789012345678901234567890123456789012

After this CL, media::BindToCurrentLoop can take OnceCallback in addition
to RepeatingCallback, and then it returns the same type of callback object,
that relays its invocation to the target thread.
==========

[tzik, 2017-05-11 07:28:40]

Description was changed from

==========
Update media::BindToCurrentLoop to support base::OnceCallback

123456789012345678901234567890123456789012345678901234567890123456789012

After this CL, media::BindToCurrentLoop can take OnceCallback in addition
to RepeatingCallback, and then it returns the same type of callback object,
that relays its invocation to the target thread.
==========

to

==========
Update media::BindToCurrentLoop to support base::OnceCallback

After this CL, media::BindToCurrentLoop can take OnceCallback in addition
to RepeatingCallback, and then it returns the same type of callback object,
that relays its invocation to the target thread.
==========

[tzik, 2017-05-11 07:29:19]

tzik@chromium.org changed reviewers:
+ maxmorin@chromium.org, xhwang@chromium.org

[tzik, 2017-05-11 07:31:44]

Description was changed from

==========
Update media::BindToCurrentLoop to support base::OnceCallback

After this CL, media::BindToCurrentLoop can take OnceCallback in addition
to RepeatingCallback, and then it returns the same type of callback object,
that relays its invocation to the target thread.
==========

to

==========
Update media::BindToCurrentLoop to support base::OnceCallback

After this CL, media::BindToCurrentLoop can take OnceCallback in addition
to RepeatingCallback, and then it returns the same type of callback object,
that relays its invocation to the target thread.

BUG=714018
==========

[tzik, 2017-05-11 07:32:58]

On 2017/05/10 13:24:33, Max Morin wrote:
> I like this CL. The BindToCurrentLoop function still needs to be copied
though,
> right?

Right, I added it.

[tzik, 2017-05-11 07:33:05]

PTAL

[Max Morin, 2017-05-11 07:45:08]

Awesome, thanks for fixing this. LGTM.

[xhwang, 2017-05-11 18:29:03]

lgtm % nits

https://codereview.chromium.org/2874003002/diff/60001/media/base/bind_to_curr...
File media/base/bind_to_current_loop.h (right):

https://codereview.chromium.org/2874003002/diff/60001/media/base/bind_to_curr...
media/base/bind_to_current_loop.h:23: //   
media::BindToCurrentLoop(base::Bind(&MyClass::MyMethod, this)));
nit: Also add an example using BindOnce?

https://codereview.chromium.org/2874003002/diff/60001/media/base/bind_to_curr...
media/base/bind_to_current_loop.h:96: FROM_HERE,
base::ThreadTaskRunnerHandle::Get(), std::move(cb)));
Do we still need the old TODO here?

// TODO(tzik): Propagate FROM_HERE from the caller.

[tzik, 2017-05-12 04:05:55]

https://codereview.chromium.org/2874003002/diff/60001/media/base/bind_to_curr...
File media/base/bind_to_current_loop.h (right):

https://codereview.chromium.org/2874003002/diff/60001/media/base/bind_to_curr...
media/base/bind_to_current_loop.h:23: //   
media::BindToCurrentLoop(base::Bind(&MyClass::MyMethod, this)));
On 2017/05/11 18:29:02, xhwang wrote:
> nit: Also add an example using BindOnce?

Done.

https://codereview.chromium.org/2874003002/diff/60001/media/base/bind_to_curr...
media/base/bind_to_current_loop.h:96: FROM_HERE,
base::ThreadTaskRunnerHandle::Get(), std::move(cb)));
On 2017/05/11 18:29:02, xhwang wrote:
> Do we still need the old TODO here?
> 
> // TODO(tzik): Propagate FROM_HERE from the caller.

Done.

[tzik, 2017-05-12 04:05:59]

The CQ bit was checked by tzik@chromium.org

[tzik, 2017-05-12 04:05:59]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
maxmorin@chromium.org
Link to the patchset: https://codereview.chromium.org/2874003002/#ps80001
(title: "+comment")

[commit-bot: I haz the power, 2017-05-12 04:06:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 05:16:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 05:16:49]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2017-05-12 07:28:41]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2017-05-12 07:29:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 08:32:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 08:32:51]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Max Morin, 2017-05-12 12:10:50]

I'll retry since the bot seems healthier now.

[Max Morin, 2017-05-12 12:10:56]

The CQ bit was checked by maxmorin@chromium.org

[commit-bot: I haz the power, 2017-05-12 12:11:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 12:37:08]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494591056645550,
"parent_rev": "2a32710d5f0e31cf648120a9724d5c8b0d8e5a88", "commit_rev":
"73c8ac7b44f40f19d829a04c069425613eebe34e"}

[commit-bot: I haz the power, 2017-05-12 12:37:21]

Description was changed from

==========
Update media::BindToCurrentLoop to support base::OnceCallback

After this CL, media::BindToCurrentLoop can take OnceCallback in addition
to RepeatingCallback, and then it returns the same type of callback object,
that relays its invocation to the target thread.

BUG=714018
==========

to

==========
Update media::BindToCurrentLoop to support base::OnceCallback

After this CL, media::BindToCurrentLoop can take OnceCallback in addition
to RepeatingCallback, and then it returns the same type of callback object,
that relays its invocation to the target thread.

BUG=714018

Review-Url: https://codereview.chromium.org/2874003002
Cr-Commit-Position: refs/heads/master@{#471285}
Committed:
https://chromium.googlesource.com/chromium/src/+/73c8ac7b44f40f19d829a04c0694...
==========

[commit-bot: I haz the power, 2017-05-12 12:37:23]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/73c8ac7b44f40f19d829a04c0694...