sanitizehtml: disallow tables

sanitizehtml: disallow tables

It is not trivial to control presentation of tables. In particular, tables do
not honor ancestor node boundaries.

Disallow them for now.

R=hinoka@chromium.org
BUG=704387
Review-Url: https://codereview.chromium.org/2873983003
Committed: https://github.com/luci/luci-go/commit/67031d2b5cda2e5a7342fd218917d6d5c61ce389

[nodir, 2017-05-10 18:26:01]

nodir@chromium.org changed reviewers:
+ xtof@google.com

[nodir, 2017-05-10 18:26:02]

HI xtof,

We've decided to disallow tables because their presentation is hard to control.
This led to simplification of the code, and thus the diff is large enough that
I'd prefer someone from security to look at this again. Most of this code is
deletion and/or simplification though. PTAL

[xtof, 2017-05-10 19:15:26]

lgtm

[nodir, 2017-05-10 19:15:57]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:16:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 19:16:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:16:08]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[nodir, 2017-05-10 19:18:12]

On 2017/05/10 19:16:08, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet.
> CQ run can only be started once the patch has received an L-G-T-M from a full
> committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
> full super star committer.
> Committers are members of the group "project-infra-committers".
> Note that this has nothing to do with OWNERS files.

Ryan, PTAL

[Vadim Sh., 2017-05-10 19:36:22]

vadimsh@chromium.org changed reviewers:
+ vadimsh@chromium.org

[Vadim Sh., 2017-05-10 19:36:22]

lgtm

[nodir, 2017-05-10 19:37:26]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:37:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 19:51:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494445046283570,
"parent_rev": "e3b4c50fa889a3825db10a0eb87adf7bc0807cb3", "commit_rev":
"67031d2b5cda2e5a7342fd218917d6d5c61ce389"}

[commit-bot: I haz the power, 2017-05-10 19:51:28]

Description was changed from

==========
sanitizehtml: disallow tables

It is not trivial to control presentation of tables. In particular, tables do
not honor ancestor node boundaries.

Disallow them for now.

R=hinoka@chromium.org
BUG=704387
==========

to

==========
sanitizehtml: disallow tables

It is not trivial to control presentation of tables. In particular, tables do
not honor ancestor node boundaries.

Disallow them for now.

R=hinoka@chromium.org
BUG=704387

Review-Url: https://codereview.chromium.org/2873983003
Committed:
https://github.com/luci/luci-go/commit/67031d2b5cda2e5a7342fd218917d6d5c61ce389
==========

[commit-bot: I haz the power, 2017-05-10 19:51:29]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/67031d2b5cda2e5a7342fd218917d6d5c61ce389