Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2873963005: Use PostTaskAndReplyWithResult in plugin_service_impl.cc. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use PostTaskAndReplyWithResult in plugin_service_impl.cc. BUG= Review-Url: https://codereview.chromium.org/2873963005 Cr-Commit-Position: refs/heads/master@{#471549} Committed: https://chromium.googlesource.com/chromium/src/+/9292e072c4320d96038eb66020e0676d38232773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -40 lines) Patch
M content/browser/loader/mime_sniffing_resource_handler_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/plugin_service_impl.h View 4 chunks +3 lines, -10 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 3 chunks +11 lines, -21 lines 0 comments Download
M content/public/browser/plugin_service.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/test/fake_plugin_service.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/fake_plugin_service.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fdoray
PTAL I plan to use this CL as an example of good coding practices at ...
3 years, 7 months ago (2017-05-11 14:54:59 UTC) #4
jam
lgtm
3 years, 7 months ago (2017-05-12 19:51:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873963005/1
3 years, 7 months ago (2017-05-13 01:48:09 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 03:48:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9292e072c4320d96038eb66020e0...

Powered by Google App Engine
This is Rietveld 408576698