Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart

Issue 2873943003: cleanup dart code completion contributors (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart b/pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart
index 397ebf42d1c8daff235e9f6e40fa9d901372dc0a..a79a63ca92d9eec7744204fdb78cec8546eb2b06 100644
--- a/pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart
@@ -75,21 +75,9 @@ part '$testFile';
});
request = await performAnalysis(200, requestCompleter);
- // Get the unresolved directives
var directives = request.target.unit.directives;
- // Assert that the import does not have an export namespace
- if (!enableNewAnalysisDriver) {
- Element element = resolutionMap.elementDeclaredByDirective(directives[0]);
- expect(element?.library?.exportNamespace, isNull);
- }
-
- // Resolve directives
- var importCompleter = new Completer<List<ImportElement>>();
- request.resolveImports().then((List<ImportElement> elements) {
- importCompleter.complete(elements);
- });
- List<ImportElement> imports = await performAnalysis(200, importCompleter);
+ List<ImportElement> imports = request.libraryElement.imports;
expect(imports, hasLength(directives.length + 1));
ImportElement importNamed(String expectedUri) {
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698