third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp - Issue 2873943002: Ensure original parser context is used when parsing resolved var() references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2873943002: Ensure original parser context is used when parsing resolved var() references (Closed)

Patch Set: g cl set-commit Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

index 370f3736702633e23c4f0a9cc9e37108924fc302..fbe6ecaf1e6a5742498cd1514c7cf826361c66cf 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

@@ -172,7 +172,8 @@ bool CSSPropertyParser::ParseValueStart(CSSPropertyID unresolved_property,

if (CSSVariableParser::ContainsValidVariableReferences(original_range)) {

bool is_animation_tainted = false;

CSSVariableReferenceValue* variable = CSSVariableReferenceValue::Create(

- CSSVariableData::Create(original_range, is_animation_tainted, true));

+ CSSVariableData::Create(original_range, is_animation_tainted, true),

+ *context_);

if (is_shorthand) {

const CSSPendingSubstitutionValue& pending_value =