Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.cpp

Issue 2873943002: Ensure original parser context is used when parsing resolved var() references (Closed)
Patch Set: g cl set-commit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.cpp b/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.cpp
index 7c48f2ac3930c04231becd3b80ea5b50c9f1bdfa..4c29033f3f394459e4664b96495cb6eeb1975558 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.cpp
+++ b/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.cpp
@@ -87,9 +87,13 @@ CSSValue* CSSUnparsedValue::ToCSSValue() const {
}
CSSTokenizer tokenizer(tokens.ToString());
- return CSSVariableReferenceValue::Create(CSSVariableData::Create(
- tokenizer.TokenRange(), false /* isAnimationTainted */,
- true /* needsVariableResolution */));
+ // TODO(alancutter): This should be using a real parser context instead of
+ // StrictCSSParserContext.
+ return CSSVariableReferenceValue::Create(
+ CSSVariableData::Create(tokenizer.TokenRange(),
+ false /* isAnimationTainted */,
+ true /* needsVariableResolution */),
+ *StrictCSSParserContext());
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698