Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pylib/gyp/generator/make.py

Issue 287393002: In "make" generator, allow spaces in paths added to LD_LIBRARY_PATH. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/generator/make.py
===================================================================
--- pylib/gyp/generator/make.py (revision 1920)
+++ pylib/gyp/generator/make.py (working copy)
@@ -887,8 +887,8 @@
# libraries, but until everything is made cross-compile safe, also use
# target libraries.
# TODO(piman): when everything is cross-compile safe, remove lib.target
- self.WriteLn('cmd_%s = LD_LIBRARY_PATH=$(builddir)/lib.host:'
- '$(builddir)/lib.target:$$LD_LIBRARY_PATH; '
+ self.WriteLn('cmd_%s = \"LD_LIBRARY_PATH=$(builddir)/lib.host:'
Michael Moss 2014/05/19 15:26:59 I think this should be: LD_LIBRARY_PATH=\"...
Bill Hesse 2014/05/19 15:34:17 Done.
+ '$(builddir)/lib.target:$$LD_LIBRARY_PATH\"; '
'export LD_LIBRARY_PATH; '
'%s%s'
% (name, cd_action, command))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698