In "make" generator, allow spaces in paths added to LD_LIBRARY_PATH.

In "make" generator, allow spaces in paths added to LD_LIBRARY_PATH.


Closing the issue, since we are moving off gyp.
It was never committed because I was unclear on how a test could be added for it.

[Bill Hesse, 2014-05-19 11:26:52]

This is the only problem with GYP make of Dart, when there are spaces in the
path.  Part of cleaning up unix and (especially) Windows build and test of Dart
when there are spaces in the path.

[Michael Moss, 2014-05-19 15:26:59]

https://codereview.chromium.org/287393002/diff/1/pylib/gyp/generator/make.py
File pylib/gyp/generator/make.py (right):

https://codereview.chromium.org/287393002/diff/1/pylib/gyp/generator/make.py#...
pylib/gyp/generator/make.py:890: self.WriteLn('cmd_%s =
\"LD_LIBRARY_PATH=$(builddir)/lib.host:'
I think this should be:

LD_LIBRARY_PATH=\"...

[Bill Hesse, 2014-05-19 15:34:17]

https://codereview.chromium.org/287393002/diff/1/pylib/gyp/generator/make.py
File pylib/gyp/generator/make.py (right):

https://codereview.chromium.org/287393002/diff/1/pylib/gyp/generator/make.py#...
pylib/gyp/generator/make.py:890: self.WriteLn('cmd_%s =
\"LD_LIBRARY_PATH=$(builddir)/lib.host:'
On 2014/05/19 15:26:59, Michael Moss wrote:
> I think this should be:
> 
> LD_LIBRARY_PATH=\"...

Done.

[Michael Moss, 2014-05-19 15:49:55]

lgtm

[Bill Hesse, 2014-05-19 16:05:36]

The CQ bit was checked by whesse@google.com

[commit-bot: I haz the power, 2014-05-19 16:10:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 16:10:07]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[Bill Hesse, 2014-05-19 16:13:49]

I will add a test.  Then, I am not sure that I am a committer.

[Bill Hesse, 2016-06-13 11:00:53]

Description was changed from

==========
In "make" generator, allow spaces in paths added to LD_LIBRARY_PATH.
==========

to

==========
In "make" generator, allow spaces in paths added to LD_LIBRARY_PATH.


Closing the issue, since we are moving off gyp.
It was never committed because I was unclear on how a test could be added for
it.
==========