Implement chrome://network-error with network service.

Implement chrome://network-error with network service.

BUG=717714
Review-Url: https://codereview.chromium.org/2873913002
Cr-Commit-Position: refs/heads/master@{#470711}
Committed: https://chromium.googlesource.com/chromium/src/+/4374b957b1158e5a05c945adec770bdcc351c808

[jam, 2017-05-10 03:49:42]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 03:50:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 06:11:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 06:11:27]

Dry run: This issue passed the CQ dry run.

[jam, 2017-05-10 14:13:00]

jam@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2017-05-10 16:29:31]

https://codereview.chromium.org/2873913002/diff/1/content/browser/webui/netwo...
File content/browser/webui/network_error_url_loader.cc (right):

https://codereview.chromium.org/2873913002/diff/1/content/browser/webui/netwo...
content/browser/webui/network_error_url_loader.cc:16: int net_error = net::OK;
Is this logic copied from somewhere else? It seems like defaulting to some sort
of error code (i.e not net::OK) would be a better default.

(I guess it's the code( in content/browser/webui/url_data_manager_backend.cc ?
It looks like an invalid error code would fallback URLRequestChromeJob in that
case.)

https://codereview.chromium.org/2873913002/diff/1/content/browser/webui/netwo...
File content/browser/webui/network_error_url_loader.h (right):

https://codereview.chromium.org/2873913002/diff/1/content/browser/webui/netwo...
content/browser/webui/network_error_url_loader.h:15: }  // namespace content
\n before }

[jam, 2017-05-10 17:33:05]

https://codereview.chromium.org/2873913002/diff/1/content/browser/webui/netwo...
File content/browser/webui/network_error_url_loader.cc (right):

https://codereview.chromium.org/2873913002/diff/1/content/browser/webui/netwo...
content/browser/webui/network_error_url_loader.cc:16: int net_error = net::OK;
On 2017/05/10 16:29:30, scottmg wrote:
> Is this logic copied from somewhere else? It seems like defaulting to some
sort
> of error code (i.e not net::OK) would be a better default.
> 
> (I guess it's the code( in content/browser/webui/url_data_manager_backend.cc ?
> It looks like an invalid error code would fallback URLRequestChromeJob in that
> case.)

Good point, defaulted to ERR_INVALID_URL which is the existing behavior.

https://codereview.chromium.org/2873913002/diff/1/content/browser/webui/netwo...
File content/browser/webui/network_error_url_loader.h (right):

https://codereview.chromium.org/2873913002/diff/1/content/browser/webui/netwo...
content/browser/webui/network_error_url_loader.h:15: }  // namespace content
On 2017/05/10 16:29:30, scottmg wrote:
> \n before }

Done.

[scottmg, 2017-05-10 17:42:01]

lgtm

[jam, 2017-05-10 17:45:40]

The CQ bit was checked by jam@chromium.org

[jam, 2017-05-10 17:45:41]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2873913002/#ps40001
(title: "merge")

[commit-bot: I haz the power, 2017-05-10 17:47:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 19:36:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:36:14]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jam, 2017-05-10 19:40:25]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:42:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 21:16:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494445225397440,
"parent_rev": "810f0dd26a5fcef7a7fed2417eac12523cfec4a8", "commit_rev":
"4374b957b1158e5a05c945adec770bdcc351c808"}

[commit-bot: I haz the power, 2017-05-10 21:17:01]

Description was changed from

==========
Implement chrome://network-error with network service.

BUG=717714
==========

to

==========
Implement chrome://network-error with network service.

BUG=717714

Review-Url: https://codereview.chromium.org/2873913002
Cr-Commit-Position: refs/heads/master@{#470711}
Committed:
https://chromium.googlesource.com/chromium/src/+/4374b957b1158e5a05c945adec77...
==========

[commit-bot: I haz the power, 2017-05-10 21:17:01]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4374b957b1158e5a05c945adec77...