Add UMA to count directory-changed events by RootType.

Add UMA to count directory-changed events by RootType.

TEST=manually verified that the histogram added to chrome://histograms/
BUG=720189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2873903004
Cr-Commit-Position: refs/heads/master@{#471181}
Committed: https://chromium.googlesource.com/chromium/src/+/60706234db798ccbc85289d12cb2160d92c2e6ee

[yamaguchi, 2017-05-10 13:36:11]

Description was changed from

==========
Add UMA for opened count of dicrectories for each RootType.

BUG=720189
==========

to

==========
Add UMA for opened count of dicrectories for each RootType.

BUG=720189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2017-05-10 13:37:08]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 13:37:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 14:46:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 14:46:11]

Dry run: This issue passed the CQ dry run.

[yamaguchi, 2017-05-11 03:24:24]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 03:26:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-05-11 04:07:43]

Description was changed from

==========
Add UMA for opened count of dicrectories for each RootType.

BUG=720189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add UMA for opened count of dicrectories for each RootType.

TEST=manually verified that the histogram added to chrome://histograms/
BUG=720189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2017-05-11 04:08:07]

yamaguchi@chromium.org changed reviewers:
+ fukino@chromium.org

[yamaguchi, 2017-05-11 04:08:08]

ptal

[fukino, 2017-05-11 04:21:47]

In this CL, we record every 'directory-changed' event.
It is not restricted to click events on directory tree.

Since the stats is not directly related to directory tree, it should not have
"directlyTree" in class name or UMA name, and it should not implemented in
directory_tree.js.

How about just listening 'directory-changed' event outside directory_tree.js?

[commit-bot: I haz the power, 2017-05-11 04:53:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:53:48]

Dry run: This issue passed the CQ dry run.

[yamaguchi, 2017-05-11 06:17:24]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 06:18:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-05-11 06:30:23]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 06:30:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-05-11 06:40:29]

Description was changed from

==========
Add UMA for opened count of dicrectories for each RootType.

TEST=manually verified that the histogram added to chrome://histograms/
BUG=720189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add UMA to count directory-changed events by RootType.

TEST=manually verified that the histogram added to chrome://histograms/
BUG=720189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2017-05-11 06:40:42]

On 2017/05/11 04:21:47, fukino wrote:
> In this CL, we record every 'directory-changed' event.
> It is not restricted to click events on directory tree.
> 
> Since the stats is not directly related to directory tree, it should not have
> "directlyTree" in class name or UMA name, and it should not implemented in
> directory_tree.js.
> 
> How about just listening 'directory-changed' event outside directory_tree.js?

Done. ptal.

[fukino, 2017-05-11 07:16:53]

lgtm with nits.
Please get reviewed by metrics owners.

https://codereview.chromium.org/2873903004/diff/80001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
(right):

https://codereview.chromium.org/2873903004/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp:78:
'../compiled_resources2.gyp:navigation_uma',
Revert this.

https://codereview.chromium.org/2873903004/diff/80001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js
(right):

https://codereview.chromium.org/2873903004/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js:149:
var directoryTreeUma = {onEntryOpened: function(entry) {}};
Revert this.

https://codereview.chromium.org/2873903004/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js:162:
true, directoryTreeUma);
ditto

[commit-bot: I haz the power, 2017-05-11 07:52:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 07:52:18]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[yamaguchi, 2017-05-11 08:06:09]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 08:06:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-05-11 09:13:10]

https://codereview.chromium.org/2873903004/diff/80001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
(right):

https://codereview.chromium.org/2873903004/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp:78:
'../compiled_resources2.gyp:navigation_uma',
On 2017/05/11 07:16:52, fukino wrote:
> Revert this.

Done.

https://codereview.chromium.org/2873903004/diff/80001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js
(right):

https://codereview.chromium.org/2873903004/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js:149:
var directoryTreeUma = {onEntryOpened: function(entry) {}};
On 2017/05/11 07:16:52, fukino wrote:
> Revert this.

Done.

https://codereview.chromium.org/2873903004/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js:162:
true, directoryTreeUma);
On 2017/05/11 07:16:52, fukino wrote:
> ditto

Done.

[yamaguchi, 2017-05-11 09:18:47]

yamaguchi@chromium.org changed reviewers:
+ jwd@chromium.org

[yamaguchi, 2017-05-11 09:18:48]

To jwd@:
Will you review tools/metrics/histograms/enums.xml and
tools/metrics/histograms/histograms.xml?

The metric is going to be used from Chrome OS.

[commit-bot: I haz the power, 2017-05-11 09:29:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 09:29:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yamaguchi, 2017-05-11 10:41:35]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 10:41:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 11:47:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 11:47:30]

Dry run: This issue passed the CQ dry run.

[jwd, 2017-05-11 19:10:16]

lgtm

[yamaguchi, 2017-05-12 01:53:53]

The CQ bit was checked by yamaguchi@chromium.org

[yamaguchi, 2017-05-12 01:53:53]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2873903004/#ps100001
(title: "Revert unused code")

[commit-bot: I haz the power, 2017-05-12 01:54:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 02:01:22]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494554033304600,
"parent_rev": "8fceabf03ed354db18981910bdbfb5a9ee31e59f", "commit_rev":
"60706234db798ccbc85289d12cb2160d92c2e6ee"}

[commit-bot: I haz the power, 2017-05-12 02:01:31]

Description was changed from

==========
Add UMA to count directory-changed events by RootType.

TEST=manually verified that the histogram added to chrome://histograms/
BUG=720189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add UMA to count directory-changed events by RootType.

TEST=manually verified that the histogram added to chrome://histograms/
BUG=720189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2873903004
Cr-Commit-Position: refs/heads/master@{#471181}
Committed:
https://chromium.googlesource.com/chromium/src/+/60706234db798ccbc85289d12cb2...
==========

[commit-bot: I haz the power, 2017-05-12 02:01:32]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/60706234db798ccbc85289d12cb2...