Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2873903003: PaymentHandler: Stop using GetAllManifests() in content side tests. (Closed)

Created:
3 years, 7 months ago by zino
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentHandler: Stop using GetAllManifests() in content side tests. The GetAllManifests() was already deprecated. Instead we should use new GetAllPaymentApps(). BUG=661608, 720040 Review-Url: https://codereview.chromium.org/2873903003 Cr-Commit-Position: refs/heads/master@{#471870} Committed: https://chromium.googlesource.com/chromium/src/+/9ade04245b96eb7ca8be76b2224711f4a832e82d

Patch Set 1 #

Patch Set 2 : PaymentHandler: Use GetAllPaymentApps() in content side. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -39 lines) Patch
M content/browser/payments/payment_app_browsertest.cc View 1 2 chunks +12 lines, -10 lines 0 comments Download
M content/browser/payments/payment_app_provider_impl_unittest.cc View 1 2 chunks +22 lines, -20 lines 0 comments Download
M content/test/data/payments/payment_app_invocation.html View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
zino
PTAL
3 years, 7 months ago (2017-05-14 09:35:50 UTC) #5
please use gerrit instead
lgtm
3 years, 7 months ago (2017-05-15 14:48:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873903003/20001
3 years, 7 months ago (2017-05-15 17:41:36 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 19:42:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9ade04245b96eb7ca8be76b22247...

Powered by Google App Engine
This is Rietveld 408576698