Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2873893004: [Sync] Add diagnostic into AndroidSyncSettingsTest (Closed)

Created:
3 years, 7 months ago by pavely
Modified:
3 years, 7 months ago
Reviewers:
skym
CC:
chromium-reviews, sync-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Add diagnostic into AndroidSyncSettingsTest After my last change tests started failing on assert in setUp claiming that getIsSyncable returns -1. I'm trying to confirm if code in AndroidSyncSettings.updateSyncability executes call to setIsSyncable, thus adding a few assertTrue. In addition I noticed that AndroidSyncSettings.mContractAuthority is initialized in ctor, but getContractAuthority() still calls mApplicationContext. I changed it to always return mContractAuthority to ensure the same value is used throughout test execution. BUG=717960 R=skym@chromium.org Review-Url: https://codereview.chromium.org/2873893004 Cr-Commit-Position: refs/heads/master@{#470697} Committed: https://chromium.googlesource.com/chromium/src/+/78577b17b468843edb79d4111471b16e55e2aaac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java View 3 chunks +2 lines, -6 lines 0 comments Download
M components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
pavely
3 years, 7 months ago (2017-05-10 19:00:44 UTC) #2
skym
lgtm
3 years, 7 months ago (2017-05-10 19:50:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873893004/1
3 years, 7 months ago (2017-05-10 19:52:15 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 20:41:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/78577b17b468843edb79d4111471...

Powered by Google App Engine
This is Rietveld 408576698