Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Unified Diff: chrome/browser/media/router/mojo/media_router_mojo_test.cc

Issue 2873893003: [Media Router] Add features to control browser side discovery (Closed)
Patch Set: resolve code review comments from Mark Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/mojo/media_router_mojo_test.cc
diff --git a/chrome/browser/media/router/mojo/media_router_mojo_test.cc b/chrome/browser/media/router/mojo/media_router_mojo_test.cc
index 567c72ecf6bd6f1695ec1994d34c5c648e880dfb..97bb467f3e177dd099d11eda41a88bfad6ba3110 100644
--- a/chrome/browser/media/router/mojo/media_router_mojo_test.cc
+++ b/chrome/browser/media/router/mojo/media_router_mojo_test.cc
@@ -11,14 +11,7 @@
namespace media_router {
namespace {
-
const char kInstanceId[] = "instance123";
-
-void ExpectEqualStrings(const std::string& expected,
- const std::string& actual) {
- EXPECT_EQ(expected, actual);
-}
-
} // namespace
MockMediaRouteProvider::MockMediaRouteProvider() {}
@@ -33,6 +26,10 @@ MockMediaController::MockMediaController() : binding_(this) {}
MockMediaController::~MockMediaController() {}
+RegisterMediaRouteProviderHandler::RegisterMediaRouteProviderHandler() {}
+
+RegisterMediaRouteProviderHandler::~RegisterMediaRouteProviderHandler() {}
+
void MockMediaController::Bind(mojom::MediaControllerRequest request) {
binding_.Bind(std::move(request));
}
@@ -80,9 +77,11 @@ void MediaRouterMojoTest::ConnectProviderManagerService() {
mojom::MediaRouteProviderPtr mojo_media_router;
binding_.reset(new mojo::Binding<mojom::MediaRouteProvider>(
&mock_media_route_provider_, mojo::MakeRequest(&mojo_media_router)));
+ EXPECT_CALL(provide_handler_, InvokeInternal(kInstanceId, testing::_));
media_router_proxy_->RegisterMediaRouteProvider(
std::move(mojo_media_router),
- base::Bind(&ExpectEqualStrings, kInstanceId));
+ base::Bind(&RegisterMediaRouteProviderHandler::Invoke,
+ base::Unretained(&provide_handler_)));
}
void MediaRouterMojoTest::SetUp() {
« no previous file with comments | « chrome/browser/media/router/mojo/media_router_mojo_test.h ('k') | chrome/common/media_router/mojo/media_router.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698