Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: chrome/browser/media/router/mojo/media_router_mojo_test.cc

Issue 2873893003: [Media Router] Add features to control browser side discovery (Closed)
Patch Set: resolve code review comments from Mark Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/router/mojo/media_router_mojo_test.h" 5 #include "chrome/browser/media/router/mojo/media_router_mojo_test.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "extensions/common/test_util.h" 10 #include "extensions/common/test_util.h"
11 11
12 namespace media_router { 12 namespace media_router {
13 namespace { 13 namespace {
14
15 const char kInstanceId[] = "instance123"; 14 const char kInstanceId[] = "instance123";
16
17 void ExpectEqualStrings(const std::string& expected,
18 const std::string& actual) {
19 EXPECT_EQ(expected, actual);
20 }
21
22 } // namespace 15 } // namespace
23 16
24 MockMediaRouteProvider::MockMediaRouteProvider() {} 17 MockMediaRouteProvider::MockMediaRouteProvider() {}
25 18
26 MockMediaRouteProvider::~MockMediaRouteProvider() {} 19 MockMediaRouteProvider::~MockMediaRouteProvider() {}
27 20
28 MockEventPageTracker::MockEventPageTracker() {} 21 MockEventPageTracker::MockEventPageTracker() {}
29 22
30 MockEventPageTracker::~MockEventPageTracker() {} 23 MockEventPageTracker::~MockEventPageTracker() {}
31 24
32 MockMediaController::MockMediaController() : binding_(this) {} 25 MockMediaController::MockMediaController() : binding_(this) {}
33 26
34 MockMediaController::~MockMediaController() {} 27 MockMediaController::~MockMediaController() {}
35 28
29 RegisterMediaRouteProviderHandler::RegisterMediaRouteProviderHandler() {}
30
31 RegisterMediaRouteProviderHandler::~RegisterMediaRouteProviderHandler() {}
32
36 void MockMediaController::Bind(mojom::MediaControllerRequest request) { 33 void MockMediaController::Bind(mojom::MediaControllerRequest request) {
37 binding_.Bind(std::move(request)); 34 binding_.Bind(std::move(request));
38 } 35 }
39 36
40 mojom::MediaControllerPtr MockMediaController::BindInterfacePtr() { 37 mojom::MediaControllerPtr MockMediaController::BindInterfacePtr() {
41 return binding_.CreateInterfacePtrAndBind(); 38 return binding_.CreateInterfacePtrAndBind();
42 } 39 }
43 40
44 void MockMediaController::CloseBinding() { 41 void MockMediaController::CloseBinding() {
45 binding_.Close(); 42 binding_.Close();
(...skipping 27 matching lines...) Expand all
73 void MediaRouterMojoTest::ConnectProviderManagerService() { 70 void MediaRouterMojoTest::ConnectProviderManagerService() {
74 // Bind the |media_route_provider| interface to |media_route_provider_|. 71 // Bind the |media_route_provider| interface to |media_route_provider_|.
75 auto request = mojo::MakeRequest(&media_router_proxy_); 72 auto request = mojo::MakeRequest(&media_router_proxy_);
76 mock_media_router_->BindToMojoRequest(std::move(request), *extension_); 73 mock_media_router_->BindToMojoRequest(std::move(request), *extension_);
77 74
78 // Bind the Mojo MediaRouter interface used by |mock_media_router_| to 75 // Bind the Mojo MediaRouter interface used by |mock_media_router_| to
79 // |mock_media_route_provider_service_|. 76 // |mock_media_route_provider_service_|.
80 mojom::MediaRouteProviderPtr mojo_media_router; 77 mojom::MediaRouteProviderPtr mojo_media_router;
81 binding_.reset(new mojo::Binding<mojom::MediaRouteProvider>( 78 binding_.reset(new mojo::Binding<mojom::MediaRouteProvider>(
82 &mock_media_route_provider_, mojo::MakeRequest(&mojo_media_router))); 79 &mock_media_route_provider_, mojo::MakeRequest(&mojo_media_router)));
80 EXPECT_CALL(provide_handler_, InvokeInternal(kInstanceId, testing::_));
83 media_router_proxy_->RegisterMediaRouteProvider( 81 media_router_proxy_->RegisterMediaRouteProvider(
84 std::move(mojo_media_router), 82 std::move(mojo_media_router),
85 base::Bind(&ExpectEqualStrings, kInstanceId)); 83 base::Bind(&RegisterMediaRouteProviderHandler::Invoke,
84 base::Unretained(&provide_handler_)));
86 } 85 }
87 86
88 void MediaRouterMojoTest::SetUp() { 87 void MediaRouterMojoTest::SetUp() {
89 ON_CALL(mock_event_page_tracker_, IsEventPageSuspended(extension_id())) 88 ON_CALL(mock_event_page_tracker_, IsEventPageSuspended(extension_id()))
90 .WillByDefault(testing::Return(false)); 89 .WillByDefault(testing::Return(false));
91 ConnectProviderManagerService(); 90 ConnectProviderManagerService();
92 base::RunLoop().RunUntilIdle(); 91 base::RunLoop().RunUntilIdle();
93 } 92 }
94 93
95 void MediaRouterMojoTest::TearDown() { 94 void MediaRouterMojoTest::TearDown() {
96 mock_media_router_->Shutdown(); 95 mock_media_router_->Shutdown();
97 } 96 }
98 97
99 void MediaRouterMojoTest::ProcessEventLoop() { 98 void MediaRouterMojoTest::ProcessEventLoop() {
100 base::RunLoop().RunUntilIdle(); 99 base::RunLoop().RunUntilIdle();
101 } 100 }
102 101
103 } // namespace media_router 102 } // namespace media_router
OLDNEW
« no previous file with comments | « chrome/browser/media/router/mojo/media_router_mojo_test.h ('k') | chrome/common/media_router/mojo/media_router.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698