Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2873863002: Don't strip DNTDocumentationSupport for hermetic bundles. (Closed)

Created:
3 years, 7 months ago by justincohen
Modified:
3 years, 6 months ago
Reviewers:
erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't strip DNTDocumentationSupport for hermetic bundles. For some reason 8.3 now requires documentation to accept the license. BUG= Review-Url: https://codereview.chromium.org/2873863002 Cr-Commit-Position: refs/heads/master@{#476286} Committed: https://chromium.googlesource.com/chromium/src/+/302d48ec6567d2e2fbc98fd71c0f76fc1af4f9fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/package_mac_toolchain.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
justincohen
ptal
3 years, 6 months ago (2017-06-01 01:22:43 UTC) #2
erikchen
lgtm
3 years, 6 months ago (2017-06-01 02:12:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873863002/1
3 years, 6 months ago (2017-06-01 14:36:07 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 14:49:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/302d48ec6567d2e2fbc98fd71c0f...

Powered by Google App Engine
This is Rietveld 408576698