Rename android_webview_test_apk

Rename android_webview_test_apk

This CL renames:
1) buildbot testing configuration files,
2) eclipse .classpath configuration,
3) build/android/pylib/results/report_results.py.

BUG=701938
Review-Url: https://codereview.chromium.org/2873833002
Cr-Commit-Position: refs/heads/master@{#470829}
Committed: https://chromium.googlesource.com/chromium/src/+/c6d9643652e2e36849a5022fd1364d437d1ee951

[Shimi Zhang, 2017-05-10 00:00:11]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 00:01:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 01:25:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 01:25:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Shimi Zhang, 2017-05-10 01:26:40]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 01:27:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 04:09:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 04:09:23]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[Shimi Zhang, 2017-05-10 16:52:59]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 16:54:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 17:58:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 17:58:32]

Dry run: This issue passed the CQ dry run.

[Shimi Zhang, 2017-05-10 18:16:13]

ctzsm@chromium.org changed reviewers:
+ jbudorick@chromium.org

[Shimi Zhang, 2017-05-10 18:16:14]

jbudorick@, PTAL.

It seems I still have one more place in catapult,
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...,
I will change that then start to remove the targets in
//src/android_webview/test/BUILD.gn

[Shimi Zhang, 2017-05-10 18:18:22]

On 2017/05/10 18:16:14, Shimi Zhang wrote:
> jbudorick@, PTAL.
> 
> It seems I still have one more place in catapult,
>
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...,
> I will change that then start to remove the targets in
> //src/android_webview/test/BUILD.gn

Forgot to mention that testing/buildbot/manage.py didn't touch
chromium.linux.json, I edited that manually.

[jbudorick, 2017-05-10 18:21:18]

It looks like you've re-alphabetized webview_instrumentation_test_apk in a few
places, but in most places it's still in the same location as
android_webview_test_apk. Can you realphabetize it everywhere?

[Shimi Zhang, 2017-05-10 21:22:37]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 21:23:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shimi Zhang, 2017-05-10 21:26:04]

On 2017/05/10 18:21:18, jbudorick wrote:
> It looks like you've re-alphabetized webview_instrumentation_test_apk in a few
> places, but in most places it's still in the same location as
> android_webview_test_apk. Can you realphabetize it everywhere?

Updated, PTAL, thanks!

There is one more thing, by updating
build/android/pylib/results/report_results.py, presubmit check asks me to update
build/android/test_runner.pydeps by running a script, and it added one more
third party dependency file, which doesn't make too much sense to me 'cause I
didn't import anything.

[wrong jbudorick, 2017-05-10 21:28:30]

On 2017/05/10 21:26:04, Shimi Zhang wrote:
> On 2017/05/10 18:21:18, jbudorick wrote:
> > It looks like you've re-alphabetized webview_instrumentation_test_apk in a
few
> > places, but in most places it's still in the same location as
> > android_webview_test_apk. Can you realphabetize it everywhere?
> 
> Updated, PTAL, thanks!
> 
> There is one more thing, by updating
> build/android/pylib/results/report_results.py, presubmit check asks me to
update
> build/android/test_runner.pydeps by running a script, and it added one more
> third party dependency file, which doesn't make too much sense to me 'cause I
> didn't import anything.

My best guess is that you've got an old local copy of catapult.

[Shimi Zhang, 2017-05-10 21:35:58]

On 2017/05/10 21:28:30, wrong jbudorick wrote:
> On 2017/05/10 21:26:04, Shimi Zhang wrote:
> > On 2017/05/10 18:21:18, jbudorick wrote:
> > > It looks like you've re-alphabetized webview_instrumentation_test_apk in a
> few
> > > places, but in most places it's still in the same location as
> > > android_webview_test_apk. Can you realphabetize it everywhere?
> > 
> > Updated, PTAL, thanks!
> > 
> > There is one more thing, by updating
> > build/android/pylib/results/report_results.py, presubmit check asks me to
> update
> > build/android/test_runner.pydeps by running a script, and it added one more
> > third party dependency file, which doesn't make too much sense to me 'cause
I
> > didn't import anything.
> 
> My best guess is that you've got an old local copy of catapult.

Yes, you are right, I checkout to master of catapult in order to update one
place there and my local master is far behind of ToT, now I updated it
correctly, thank you!

[jbudorick, 2017-05-10 21:43:19]

lgtm w/ nit

https://codereview.chromium.org/2873833002/diff/60001/testing/buildbot/chromi...
File testing/buildbot/chromium.android.json (right):

https://codereview.chromium.org/2873833002/diff/60001/testing/buildbot/chromi...
testing/buildbot/chromium.android.json:4896: {
Duplicate?

[Shimi Zhang, 2017-05-10 21:50:15]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[Shimi Zhang, 2017-05-10 21:50:39]

https://codereview.chromium.org/2873833002/diff/60001/testing/buildbot/chromi...
File testing/buildbot/chromium.android.json (right):

https://codereview.chromium.org/2873833002/diff/60001/testing/buildbot/chromi...
testing/buildbot/chromium.android.json:4896: {
On 2017/05/10 21:43:18, jbudorick wrote:
> Duplicate?

The later one has one more args --enable-browser-side-navigation, and it's name
is browser_side_navigation_webview_instrumentation_test_apk, although they have
the same test entries. I was confused at the beginning too.

[commit-bot: I haz the power, 2017-05-10 21:51:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shimi Zhang, 2017-05-10 22:06:31]

Description was changed from

==========
Rename android_webview_test_apk

This patch renames buildbot testing configuration files,
also renames eclipse .classpath configuration.

BUG=701938
==========

to

==========
Rename android_webview_test_apk

This CL renames:
1) buildbot testing configuration files,
2) eclipse .classpath configuration,
3) build/android/pylib/results/report_results.py.

BUG=701938
==========

[commit-bot: I haz the power, 2017-05-11 03:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 03:53:46]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Shimi Zhang, 2017-05-11 04:41:09]

The CQ bit was checked by ctzsm@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:42:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 05:48:35]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494477669762050,
"parent_rev": "06f33f6fa8d71e31838103a0e12f95e8420510d2", "commit_rev":
"c6d9643652e2e36849a5022fd1364d437d1ee951"}

[commit-bot: I haz the power, 2017-05-11 05:48:44]

Description was changed from

==========
Rename android_webview_test_apk

This CL renames:
1) buildbot testing configuration files,
2) eclipse .classpath configuration,
3) build/android/pylib/results/report_results.py.

BUG=701938
==========

to

==========
Rename android_webview_test_apk

This CL renames:
1) buildbot testing configuration files,
2) eclipse .classpath configuration,
3) build/android/pylib/results/report_results.py.

BUG=701938

Review-Url: https://codereview.chromium.org/2873833002
Cr-Commit-Position: refs/heads/master@{#470829}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6d9643652e2e36849a5022fd136...
==========

[commit-bot: I haz the power, 2017-05-11 05:48:45]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c6d9643652e2e36849a5022fd136...