Implement getMediaDevices.

content/browser/renderer_host/media/media_stream_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/media/media_stream_manager.h"
 
 #include <list>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 143 matching lines @@
     }
   }
   return output_string;
 }
 
 // Needed for MediaStreamManager::GenerateStream below.
 std::string ReturnEmptySalt() {
   return std::string();
 }
 
+// Clears the MediaStreamDevice.name from all devices in |device_list|.

[mcasas, 2014/05/27 12:08:23]

s/|device_list|/|devices|/

[Henrik Grunell, 2014/05/27 15:33:54]

Done.

+static void ClearDeviceLabels(content::StreamDeviceInfoArray* devices) {
+  for (content::StreamDeviceInfoArray::iterator device_itr = devices->begin();
+       device_itr != devices->end();
+       ++device_itr) {
+    device_itr->device.name.clear();
+  }
+}
+
 }  // namespace
 
 
 // MediaStreamManager::DeviceRequest represents a request to either enumerate
 // available devices or open one or more devices.
 // TODO(perkj): MediaStreamManager still needs refactoring. I propose we create
 // several subclasses of DeviceRequest and move some of the responsibility of
 // the MediaStreamManager to the subclasses to get rid of the way too many if
 // statements in MediaStreamManager.
 class MediaStreamManager::DeviceRequest {
  public:
   DeviceRequest(MediaStreamRequester* requester,
                 int requesting_process_id,
                 int requesting_view_id,
                 int page_request_id,
                 const GURL& security_origin,
+                ResourceContext* resource_context,
                 bool user_gesture,
                 MediaStreamRequestType request_type,
                 const StreamOptions& options,
                 const ResourceContext::SaltCallback& salt_callback)
       : requester(requester),
         requesting_process_id(requesting_process_id),
         requesting_view_id(requesting_view_id),
         page_request_id(page_request_id),
         security_origin(security_origin),
+        resource_context(resource_context),
         user_gesture(user_gesture),
         request_type(request_type),
         options(options),
         salt_callback(salt_callback),
         state_(NUM_MEDIA_TYPES, MEDIA_REQUEST_STATE_NOT_REQUESTED),
         audio_type_(MEDIA_NO_SERVICE),
         video_type_(MEDIA_NO_SERVICE) {
   }
 
   ~DeviceRequest() {}
@@ skipping 101 matching lines @@
   // will receive a handle to the MediaStream. This may be different from
   // MediaStreamRequest::render_view_id which in the tab capture case
   // specifies the target renderer from which audio and video is captured.
   const int requesting_view_id;
 
   // An ID the render view provided to identify this request.
   const int page_request_id;
 
   const GURL security_origin;
 
+  // This is used when enumerating devices for checking if we have device
+  // permission, and if not remove the device label.
+  ResourceContext* resource_context;
+
   const bool user_gesture;
 
   const MediaStreamRequestType request_type;
 
   const StreamOptions options;
 
   ResourceContext::SaltCallback salt_callback;
 
   StreamDeviceInfoArray devices;
 
@@ skipping 84 matching lines @@
     const MediaRequestResponseCallback& callback) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
 
   // TODO(perkj): The argument list with NULL parameters to DeviceRequest
   // suggests that this is the wrong design. Can this be refactored?
   DeviceRequest* request = new DeviceRequest(NULL,
                                              render_process_id,
                                              render_view_id,
                                              page_request_id,
                                              security_origin,
+                                             NULL,
                                              false,  // user gesture
                                              MEDIA_DEVICE_ACCESS,
                                              options,
                                              base::Bind(&ReturnEmptySalt));
 
   const std::string& label = AddRequest(request);
 
   request->callback = callback;
   // Post a task and handle the request asynchronously. The reason is that the
   // requester won't have a label for the request until this function returns
@@ skipping 20 matching lines @@
   if (CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kUseFakeUIForMediaStream)) {
     UseFakeUI(scoped_ptr<FakeMediaStreamUIProxy>());
   }
 
   DeviceRequest* request = new DeviceRequest(requester,
                                              render_process_id,
                                              render_view_id,
                                              page_request_id,
                                              security_origin,
+                                             NULL,
                                              user_gesture,
                                              MEDIA_GENERATE_STREAM,
                                              options,
                                              sc);
 
   const std::string& label = AddRequest(request);
 
   // Post a task and handle the request asynchronously. The reason is that the
   // requester won't have a label for the request until this function returns
   // and thus can not handle a response. Using base::Unretained is safe since
@@ skipping 162 matching lines @@
   }
 }
 
 std::string MediaStreamManager::EnumerateDevices(
     MediaStreamRequester* requester,
     int render_process_id,
     int render_view_id,
     const ResourceContext::SaltCallback& sc,
     int page_request_id,
     MediaStreamType type,
-    const GURL& security_origin) {
+    const GURL& security_origin,
+    ResourceContext* resource_context) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   DCHECK(requester);
   DCHECK(type == MEDIA_DEVICE_AUDIO_CAPTURE ||
          type == MEDIA_DEVICE_VIDEO_CAPTURE);
 
   DeviceRequest* request = new DeviceRequest(requester,
                                              render_process_id,
                                              render_view_id,
                                              page_request_id,
                                              security_origin,
+                                             resource_context,

[perkj_chrome, 2014/05/27 11:57:23]

This is not safe. Why not check the permissions and inject that info into
MediaStreamManager::EnumerateDevices instead?

[Henrik Grunell, 2014/05/27 15:33:54]

Done.

                                              false,  // user gesture
                                              MEDIA_ENUMERATE_DEVICES,
                                              StreamOptions(),
                                              sc);
   if (IsAudioMediaType(type))
     request->SetAudioType(type);
   else if (IsVideoMediaType(type))
     request->SetVideoType(type);
 
   const std::string& label = AddRequest(request);
@@ skipping 11 matching lines @@
 
 void MediaStreamManager::DoEnumerateDevices(const std::string& label) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   DeviceRequest* request = FindRequest(label);
   if (!request)
     return;  // This can happen if the request has been canceled.
 
   MediaStreamType type;
   EnumerationCache* cache;
   if (request->audio_type() == MEDIA_DEVICE_AUDIO_CAPTURE) {
     DCHECK_EQ(MEDIA_NO_SERVICE, request->video_type());

[mcasas, 2014/05/27 12:08:23]

I know this is not your code, but does this mean 
we are not expecting a Video request next to an Audio
request? And if so ('cause they come segregated 
I understand), shouldn't we check in l.701 for

DCHECK_EQ(MEDIA_NO_SERVICE, request->audio_type());
?

[Henrik Grunell, 2014/05/27 15:33:54]

AFAIK only one type per request. Agree on the added dcheck. Done.

     type = MEDIA_DEVICE_AUDIO_CAPTURE;
     cache = &audio_enumeration_cache_;
   } else {
     DCHECK_EQ(MEDIA_DEVICE_VIDEO_CAPTURE, request->video_type());
     type = MEDIA_DEVICE_VIDEO_CAPTURE;
     cache = &video_enumeration_cache_;
   }
 
   if (!EnumerationRequired(cache, type)) {
     // Cached device list of this type exists. Just send it out.
@@ skipping 28 matching lines @@
     options.mandatory_video.push_back(
         StreamOptions::Constraint(kMediaStreamSourceInfoId, device_id));
   } else {
     NOTREACHED();
   }
   DeviceRequest* request = new DeviceRequest(requester,
                                              render_process_id,
                                              render_view_id,
                                              page_request_id,
                                              security_origin,
+                                             NULL,
                                              false,  // user gesture
                                              MEDIA_OPEN_DEVICE,
                                              options,
                                              sc);
 
   const std::string& label = AddRequest(request);
   // Post a task and handle the request asynchronously. The reason is that the
   // requester won't have a label for the request until this function returns
   // and thus can not handle a response. Using base::Unretained is safe since
   // MediaStreamManager is deleted on the UI thread, after the IO thread has
@@ skipping 621 matching lines @@
   const StreamDeviceInfoArray& requested_devices = request->devices;
   request->requester->DeviceOpened(request->requesting_view_id,
                                    request->page_request_id,
                                    label, requested_devices.front());
 }
 
 void MediaStreamManager::FinalizeEnumerateDevices(const std::string& label,
                                                   DeviceRequest* request) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   DCHECK_EQ(request->request_type, MEDIA_ENUMERATE_DEVICES);
+  DCHECK(request->resource_context);
 

[mcasas, 2014/05/27 12:08:23]

DCHECK(request->state(type), MEDIA_REQUEST_STATE_DONE); ?

[Henrik Grunell, 2014/05/27 15:33:54]

According to xians@, no.

   if (request->security_origin.is_valid()) {
     for (StreamDeviceInfoArray::iterator it = request->devices.begin();
          it != request->devices.end(); ++it) {
       TranslateDeviceIdToSourceId(request, &it->device);
     }
   } else {
     request->devices.clear();
   }
 
+  // Query for mic and camera permissions.

[mcasas, 2014/05/27 12:08:23]

This might sound silly, but aren't we querying for
permission after the devices have been enumerated?

[Henrik Grunell, 2014/05/27 15:33:54]

Changed based on other comment to check permission before calling enumeration.
(In DeviceRequestMessageFilter it's actually done after, hence the check here.)

+  bool visible_labels = request->audio_type() == MEDIA_DEVICE_AUDIO_CAPTURE ?
+      request->resource_context->AllowMicAccess(request->security_origin) :
+      request->resource_context->AllowCameraAccess(request->security_origin);
+  if (!visible_labels)
+    ClearDeviceLabels(&request->devices);

[perkj_chrome, 2014/05/27 11:57:23]

Is this ok with Pepper? 

[Henrik Grunell, 2014/05/27 15:33:54]

Still no clear answer from them. I'll let someone there review the code.

+
   request->requester->DevicesEnumerated(
       request->requesting_view_id,
       request->page_request_id,
       label,
       request->devices);
 
   // TODO(tommi):
   // Ideally enumeration requests should be deleted once they have been served
   // (as any request).  However, this implementation mixes requests and
   // notifications together so enumeration requests are kept open by some
@@ skipping 539 matching lines @@
       if (it->device.type == MEDIA_DESKTOP_VIDEO_CAPTURE) {
         video_capture_manager_->SetDesktopCaptureWindowId(it->session_id,
                                                           window_id);
         break;
       }
     }
   }
 }
 
 }  // namespace content