Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2873823002: Put PaintInvalidatorContext on the heap, to reduce stack overflows. (Closed)

Created:
3 years, 7 months ago by chrishtr
Modified:
3 years, 7 months ago
Reviewers:
pdr., Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Put PaintInvalidatorContext on the heap, to reduce stack overflows. BUG=718386 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2873823002 Cr-Commit-Position: refs/heads/master@{#471160} Committed: https://chromium.googlesource.com/chromium/src/+/6c53f5db1411329c6662a40b4973a3af20b80ab5

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Patch Set 4 : Merge branch 'master' into fastmallocpaintinvalidator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M third_party/WebKit/Source/core/paint/PaintInvalidator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 1 2 8 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
chrishtr
3 years, 7 months ago (2017-05-09 23:31:18 UTC) #4
pdr.
LGTM
3 years, 7 months ago (2017-05-09 23:33:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873823002/40001
3 years, 7 months ago (2017-05-09 23:42:49 UTC) #8
Xianzhu
lgtm
3 years, 7 months ago (2017-05-09 23:52:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/289770)
3 years, 7 months ago (2017-05-10 00:14:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873823002/60001
3 years, 7 months ago (2017-05-11 14:57:28 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/175984)
3 years, 7 months ago (2017-05-11 16:16:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873823002/60001
3 years, 7 months ago (2017-05-11 22:59:55 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 01:11:39 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6c53f5db1411329c6662a40b4973...

Powered by Google App Engine
This is Rietveld 408576698