Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2873763003: Rename and move ExperimentalMacRTL flag (Closed)

Created:
3 years, 7 months ago by lgrey
Modified:
3 years, 7 months ago
Reviewers:
Elly Fong-Jones
CC:
chromium-reviews, jshin+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename and move ExperimentalMacRTL flag In anticipation of adding it to chrome://flags BUG=673362 Review-Url: https://codereview.chromium.org/2873763003 Cr-Commit-Position: refs/heads/master@{#470586} Committed: https://chromium.googlesource.com/chromium/src/+/591540b12bcfe11d368bf9341c7f160ead3e36dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M chrome/browser/ui/cocoa/l10n_util.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/l10n_util.mm View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/test/scoped_force_rtl_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_features.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
lgrey
PTAL :)
3 years, 7 months ago (2017-05-09 23:12:11 UTC) #2
Elly Fong-Jones
lgtm
3 years, 7 months ago (2017-05-10 14:42:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873763003/1
3 years, 7 months ago (2017-05-10 14:43:49 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 15:52:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/591540b12bcfe11d368bf9341c7f...

Powered by Google App Engine
This is Rietveld 408576698