Introduce SingleThreadTaskRunnerThreadMode

Introduce SingleThreadTaskRunnerThreadMode

This allows callers creating SingleThreadTaskRunners to specify if the
backing thread for the SingleThreadTaskRunner can be shared with other
task runners or reserved for the exclusive use of the
SingleThreadTaskRunner.

BUG=720058
Review-Url: https://codereview.chromium.org/2873733003
Cr-Commit-Position: refs/heads/master@{#471287}
Committed: https://chromium.googlesource.com/chromium/src/+/94520d71c9197a0f9b0bf4b426e4d676725828d1

[robliao, 2017-05-09 21:50:13]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 21:51:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robliao, 2017-05-09 23:16:55]

Description was changed from

==========
Introduce SingleThreadTaskRunnerThreadMode

This allows callers creating SingleThreadTaskRunners to specify if the
backing thread for the SingleThreadTaskRunner can be shared with other
task runners or reserved for the exclusive use of the
SingleThreadTaskRunner.

BUG=720058
==========

to

==========
Introduce SingleThreadTaskRunnerThreadMode

This allows callers creating SingleThreadTaskRunners to specify if the
backing thread for the SingleThreadTaskRunner can be shared with other
task runners or reserved for the exclusive use of the
SingleThreadTaskRunner.

BUG=720058
==========

[robliao, 2017-05-09 23:16:56]

robliao@chromium.org changed reviewers:
+ fdoray@chromium.org, gab@chromium.org

[robliao, 2017-05-09 23:17:22]

Here's the design compromise to avoid churning the TaskTraits types.

[commit-bot: I haz the power, 2017-05-09 23:53:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 23:53:58]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[fdoray, 2017-05-10 12:32:24]

https://codereview.chromium.org/2873733003/diff/1/base/task_scheduler/task_sc...
File base/task_scheduler/task_scheduler.h (right):

https://codereview.chromium.org/2873733003/diff/1/base/task_scheduler/task_sc...
base/task_scheduler/task_scheduler.h:64: enum class
SingleThreadTaskRunnerThreadMode {
Declare this in a separate file, so that post_task.h doesn't have to include
task_scheduler.h to support this. We wouldn't want task_scheduler.h to be
included in every file that includes post_task.h.

[gab, 2017-05-10 15:20:47]

lgtm w/ comment

https://codereview.chromium.org/2873733003/diff/1/base/task_scheduler/task_sc...
File base/task_scheduler/task_scheduler.h (right):

https://codereview.chromium.org/2873733003/diff/1/base/task_scheduler/task_sc...
base/task_scheduler/task_scheduler.h:64: enum class
SingleThreadTaskRunnerThreadMode {
On 2017/05/10 12:32:23, fdoray wrote:
> Declare this in a separate file, so that post_task.h doesn't have to include
> task_scheduler.h to support this. We wouldn't want task_scheduler.h to be
> included in every file that includes post_task.h.

Agreed, feels like this belongs in task_traits.h or post_task.h, people using
post_task.h shouldn't have to include extra headers to be able to use the API
(and as Francois said we don't wait task_scheduler.h to be implicitly included
everywhere)

[robliao, 2017-05-11 04:51:46]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 04:52:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 04:58:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:58:34]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[robliao, 2017-05-11 05:14:37]

Patchset #2 (id:20001) has been deleted

[robliao, 2017-05-11 05:29:19]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[robliao, 2017-05-11 05:30:12]

https://codereview.chromium.org/2873733003/diff/1/base/task_scheduler/task_sc...
File base/task_scheduler/task_scheduler.h (right):

https://codereview.chromium.org/2873733003/diff/1/base/task_scheduler/task_sc...
base/task_scheduler/task_scheduler.h:64: enum class
SingleThreadTaskRunnerThreadMode {
On 2017/05/10 15:20:47, gab wrote:
> On 2017/05/10 12:32:23, fdoray wrote:
> > Declare this in a separate file, so that post_task.h doesn't have to include
> > task_scheduler.h to support this. We wouldn't want task_scheduler.h to be
> > included in every file that includes post_task.h.
> 
> Agreed, feels like this belongs in task_traits.h or post_task.h, people using
> post_task.h shouldn't have to include extra headers to be able to use the API
> (and as Francois said we don't wait task_scheduler.h to be implicitly included
> everywhere)

Went with a new file. This isn't really part of Task Traits by design, so it
didn't really make sense for it to go there. Having TaskScheduler* include
post_task.h also seemed circular, resulting in the new file.

[commit-bot: I haz the power, 2017-05-11 05:30:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 07:23:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 07:23:20]

Dry run: This issue passed the CQ dry run.

[fdoray, 2017-05-11 12:17:23]

lgtm

[gab, 2017-05-11 13:48:24]

lgtm

https://codereview.chromium.org/2873733003/diff/60001/base/task_scheduler/sin...
File base/task_scheduler/single_thread_task_runner_thread_mode.h (right):

https://codereview.chromium.org/2873733003/diff/60001/base/task_scheduler/sin...
base/task_scheduler/single_thread_task_runner_thread_mode.h:23: }  // namespace
// namespace base

[robliao, 2017-05-12 04:31:05]

https://codereview.chromium.org/2873733003/diff/60001/base/task_scheduler/sin...
File base/task_scheduler/single_thread_task_runner_thread_mode.h (right):

https://codereview.chromium.org/2873733003/diff/60001/base/task_scheduler/sin...
base/task_scheduler/single_thread_task_runner_thread_mode.h:23: }  // namespace
On 2017/05/11 13:48:23, gab wrote:
> // namespace base

Done.

[robliao, 2017-05-12 04:31:09]

The CQ bit was checked by robliao@chromium.org

[robliao, 2017-05-12 04:31:09]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
fdoray@chromium.org
Link to the patchset: https://codereview.chromium.org/2873733003/#ps80001
(title: "Add missing "base"")

[commit-bot: I haz the power, 2017-05-12 04:31:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 06:04:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 06:04:32]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fdoray, 2017-05-12 12:04:12]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-05-12 12:04:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 12:43:41]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494590652180300,
"parent_rev": "897fedad953f7ef4d6d092e3f7ad6d7a34900eea", "commit_rev":
"94520d71c9197a0f9b0bf4b426e4d676725828d1"}

[commit-bot: I haz the power, 2017-05-12 12:43:53]

Description was changed from

==========
Introduce SingleThreadTaskRunnerThreadMode

This allows callers creating SingleThreadTaskRunners to specify if the
backing thread for the SingleThreadTaskRunner can be shared with other
task runners or reserved for the exclusive use of the
SingleThreadTaskRunner.

BUG=720058
==========

to

==========
Introduce SingleThreadTaskRunnerThreadMode

This allows callers creating SingleThreadTaskRunners to specify if the
backing thread for the SingleThreadTaskRunner can be shared with other
task runners or reserved for the exclusive use of the
SingleThreadTaskRunner.

BUG=720058

Review-Url: https://codereview.chromium.org/2873733003
Cr-Commit-Position: refs/heads/master@{#471287}
Committed:
https://chromium.googlesource.com/chromium/src/+/94520d71c9197a0f9b0bf4b426e4...
==========

[commit-bot: I haz the power, 2017-05-12 12:43:54]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/94520d71c9197a0f9b0bf4b426e4...