Issue 287373004: Revert of Add default options for ThreadSanitizer on Linux. Enable deadlock detection by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 287373004: Revert of Add default options for ThreadSanitizer on Linux. Enable deadlock detection by default. (Closed)

Created:
6 years, 7 months ago by Jeffrey Yasskin

Modified:
6 years, 7 months ago

Reviewers:
Alexander Potapenko, earthdok

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Add default options for ThreadSanitizer on Linux. Enable deadlock detection by default. (https://codereview.chromium.org/272763005/) Reason for revert: The linux_clan_tsan trybot caught a few deadlock reports that break memory bots after this change. e.g. http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28TSan%20v2%29%281%29/builds/9705/steps/media_unittests/logs/stdio Original issue's description: > Add default options for ThreadSanitizer on Linux. Enable deadlock detection by default. > > BUG=372754, 302040 > R=earthdok@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271412 TBR=earthdok@chromium.org,glider@chromium.org NOTREECHECKS=true NOTRY=true BUG=372754, 302040 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271447

Created: 6 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -18 lines)			Patch
	M	base/debug/sanitizer_options.cc	View		1 chunk	+0 lines, -18 lines	0 comments	Download

Total messages: 3 (0 generated)

Jeffrey Yasskin

Created Revert of Add default options for ThreadSanitizer on Linux. Enable deadlock detection by default.

6 years, 7 months ago (2014-05-19 19:07:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/287373004/1

6 years, 7 months ago (2014-05-19 19:08:43 UTC) #2

Message was sent while issue was closed.

Change committed as 271447