Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2873723002: Add link to flakiness dashboard for each test case (Closed)

Created:
3 years, 7 months ago by BigBossZhiling
Modified:
3 years, 7 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add link to flakiness dashboard for each test case Create a link to flakiness dashboard for each test case, so that engineers will see the flakiness level for that test case. BUG=717631 Review-Url: https://codereview.chromium.org/2873723002 Cr-Commit-Position: refs/heads/master@{#471122} Committed: https://chromium.googlesource.com/chromium/src/+/20892f4eb9dad7ed0b1720dc3718dbc5db5f0d7f

Patch Set 1 #

Patch Set 2 : enable tombstones #

Patch Set 3 : flakiness link #

Patch Set 4 : fixes #

Patch Set 5 : fixes #

Patch Set 6 : fix build.gn #

Patch Set 7 : remove crashed testcase #

Total comments: 6

Patch Set 8 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M build/android/pylib/results/presentation/test_results_presentation.py View 1 2 3 4 5 6 7 5 chunks +21 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
BigBossZhiling
3 years, 7 months ago (2017-05-10 20:03:55 UTC) #3
jbudorick
lgtm w/ nits https://codereview.chromium.org/2873723002/diff/120001/build/android/pylib/results/presentation/test_results_presentation.py File build/android/pylib/results/presentation/test_results_presentation.py (right): https://codereview.chromium.org/2873723002/diff/120001/build/android/pylib/results/presentation/test_results_presentation.py#newcode117 build/android/pylib/results/presentation/test_results_presentation.py:117: data='flakiness', nit: 4 space indent https://codereview.chromium.org/2873723002/diff/120001/build/android/pylib/results/presentation/test_results_presentation.py#newcode174 ...
3 years, 7 months ago (2017-05-11 18:21:08 UTC) #4
jbudorick
https://codereview.chromium.org/2873723002/diff/120001/tools/mb/mb.py File tools/mb/mb.py (right): https://codereview.chromium.org/2873723002/diff/120001/tools/mb/mb.py#newcode1095 tools/mb/mb.py:1095: '--store-tombstones'] actually, this shouldn't be necessary for flakiness dashboard ...
3 years, 7 months ago (2017-05-11 18:21:30 UTC) #5
BigBossZhiling
https://codereview.chromium.org/2873723002/diff/120001/build/android/pylib/results/presentation/test_results_presentation.py File build/android/pylib/results/presentation/test_results_presentation.py (right): https://codereview.chromium.org/2873723002/diff/120001/build/android/pylib/results/presentation/test_results_presentation.py#newcode117 build/android/pylib/results/presentation/test_results_presentation.py:117: data='flakiness', On 2017/05/11 18:21:08, jbudorick wrote: > nit: 4 ...
3 years, 7 months ago (2017-05-11 21:47:56 UTC) #8
BigBossZhiling
3 years, 7 months ago (2017-05-11 21:47:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873723002/140001
3 years, 7 months ago (2017-05-11 21:49:25 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 23:45:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/20892f4eb9dad7ed0b1720dc3718...

Powered by Google App Engine
This is Rietveld 408576698