[DevTools] added creation stack for event listeners without scheduled stack

[DevTools] added creation stack for event listeners without scheduled stack

BUG=v8:6189
R=dgozman@chromium.org

[kozy, 2017-05-09 18:09:39]

Dmitry, please take a look.

https://codereview.chromium.org/2873713002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-events-expected.txt
(right):

https://codereview.chromium.org/2873713002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-events-expected.txt:26:
0) doTestSelectionChange (async-callstack-events.html:30)
We probably would not like to replace stack if it already exists. Or we just
need advanced mode where we show old scheduled stacks.

[kozy, 2017-05-10 00:23:38]

Description was changed from

==========
[DevTools] replaced schedule async tail with creation for event listeners

BUG=v8:6189
R=dgozman@chromium.org
==========

to

==========
[DevTools] added creation stack for event listeners without scheduled stack

BUG=v8:6189
R=dgozman@chromium.org
==========

[kozy, 2017-05-10 00:41:34]

Dmitry, please take another look!

[dgozman, 2017-05-10 18:36:30]

Let's also remove unneeded instrumentation in this patch.

https://codereview.chromium.org/2873713002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp
(right):

https://codereview.chromium.org/2873713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp:64:
probe::AsyncTaskScheduled(CurrentExecutionContext(isolate), "Event Listener",
Can we have an event name? I really liked it. E.g. "click event".

https://codereview.chromium.org/2873713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp:69:
probe::AsyncTaskCanceled(CurrentExecutionContext(isolate_), this);
I am worried CurrentExecutionContext() could be wrong here.

https://codereview.chromium.org/2873713002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/probe/CoreProbes.cpp (right):

https://codereview.chromium.org/2873713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/probe/CoreProbes.cpp:69: if (optional &&
debugger_->IsRunningAsyncTask()) {
Instead of calling this, pass optional to AsyncTaskStarted.

[kozy, 2017-05-10 21:24:01]

all done, please take a look.

https://codereview.chromium.org/2873713002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp
(right):

https://codereview.chromium.org/2873713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp:64:
probe::AsyncTaskScheduled(CurrentExecutionContext(isolate), "Event Listener",
On 2017/05/10 18:36:30, dgozman wrote:
> Can we have an event name? I really liked it. E.g. "click event".

Done.

https://codereview.chromium.org/2873713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp:69:
probe::AsyncTaskCanceled(CurrentExecutionContext(isolate_), this);
On 2017/05/10 18:36:30, dgozman wrote:
> I am worried CurrentExecutionContext() could be wrong here.

Done.

https://codereview.chromium.org/2873713002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/probe/CoreProbes.cpp (right):

https://codereview.chromium.org/2873713002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/probe/CoreProbes.cpp:69: if (optional &&
debugger_->IsRunningAsyncTask()) {
On 2017/05/10 18:36:30, dgozman wrote:
> Instead of calling this, pass optional to AsyncTaskStarted.

Done.

[kozy, 2017-05-17 20:10:15]

Dmitry, please take another look.

[kozy, 2017-05-17 20:10:19]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 20:11:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 21:07:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 21:07:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2017-07-15 05:54:30]

What's the plan here?