third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp - Issue 2873713002: [DevTools] added creation stack for event listeners without scheduled stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

Issue 2873713002: [DevTools] added creation stack for event listeners without scheduled stack

Patch Set: better Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-uncaught-promise-in-worker-expected.txt ('k') | third_party/WebKit/Source/core/events/EventTarget.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

index e8a8543bb382f5a40c2c4c28808cbb055c7739f9..58f714011750b829b013cd65d66c7902b4501164 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

@@ -40,6 +40,7 @@

#include "core/dom/ExecutionContext.h"

#include "core/events/BeforeUnloadEvent.h"

#include "core/events/Event.h"

+#include "core/probe/CoreProbes.h"

#include "core/workers/WorkerGlobalScope.h"

#include "platform/InstanceCounters.h"

#include "platform/bindings/V8PrivateProperty.h"

@@ -218,6 +219,7 @@ void V8AbstractEventListener::ClearListenerObject() {

if (!HasExistingListenerObject())

return;

listener_.Clear();

+ probe::AsyncTaskCanceled(CurrentExecutionContext(isolate_), this);

if (worker_global_scope_) {

worker_global_scope_->DeregisterEventListener(this);

} else {