Add unit tests for NTLMv1 portable implementation

net/BUILD.gn

Index: net/BUILD.gn
diff --git a/net/BUILD.gn b/net/BUILD.gn
index df4d4507c0bedf6d3ce274de494fabc405067f08..162592bf3cb10613e47d38504cbafd6718c022c2 100644
--- a/net/BUILD.gn
+++ b/net/BUILD.gn
@@ -290,6 +290,8 @@ component("net") {
     "http/ntlm_buffer_reader.h",
     "http/ntlm_buffer_writer.cc",
     "http/ntlm_buffer_writer.h",
+    "http/ntlm_client.cc",
+    "http/ntlm_client.h",

[asanka, 2017/06/23 21:29:10]

I'm guessing this and the tests would be moved to //net/ntlm and would only be
added as a dependency to //net on platforms other than Windows.

[zentaro, 2017/07/05 17:57:40]

Done.

     "http/transport_security_state.cc",
     "http/transport_security_state.h",
     "http/transport_security_state_source.h",
@@ -4684,6 +4686,7 @@ test("net_unittests") {
     "http/http_auth_handler_mock.cc",
     "http/http_auth_handler_mock.h",
     "http/http_auth_handler_negotiate_unittest.cc",
+    "http/http_auth_handler_ntlm_portable_unittest.cc",

[asanka, 2017/06/23 21:29:10]

inside the 'test("net_unittests")' definition, add a condition to remove this
source file when 'is_win' is true.

[zentaro, 2017/07/05 17:57:41]

Since I already added a condition for !is_win for the other test I add this
there rather than doing the inverse.

     "http/http_auth_handler_unittest.cc",
     "http/http_auth_multi_round_parse_unittest.cc",
     "http/http_auth_preferences_unittest.cc",
@@ -4724,6 +4727,7 @@ test("net_unittests") {
     "http/mock_sspi_library_win.h",
     "http/ntlm_buffer_reader_unittest.cc",
     "http/ntlm_buffer_writer_unittest.cc",
+    "http/ntlm_client_unittest.cc",
     "http/transport_security_persister_unittest.cc",
     "http/transport_security_state_unittest.cc",
     "http/url_security_manager_unittest.cc",