Add unit tests for NTLMv1 portable implementation

net/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//build/config/chromecast_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
@@ skipping 272 matching lines @@
     "http/http_status_code_list",
     "http/http_util.cc",
     "http/http_util.h",
     "http/http_vary_data.cc",
     "http/http_vary_data.h",
     "http/ntlm.h",
     "http/ntlm_buffer_reader.cc",
     "http/ntlm_buffer_reader.h",
     "http/ntlm_buffer_writer.cc",
     "http/ntlm_buffer_writer.h",
+    "http/ntlm_client.cc",
+    "http/ntlm_client.h",

[asanka, 2017/06/23 21:29:10]

I'm guessing this and the tests would be moved to //net/ntlm and would only be
added as a dependency to //net on platforms other than Windows.

[zentaro, 2017/07/05 17:57:40]

Done.

     "http/transport_security_state.cc",
     "http/transport_security_state.h",
     "http/transport_security_state_source.h",
     "log/net_log.cc",
     "log/net_log.h",
     "log/net_log_capture_mode.cc",
     "log/net_log_capture_mode.h",
     "log/net_log_entry.cc",
     "log/net_log_entry.h",
     "log/net_log_event_type.h",
@@ skipping 4374 matching lines @@
     "http/http_auth_challenge_tokenizer_unittest.cc",
     "http/http_auth_controller_unittest.cc",
     "http/http_auth_filter_unittest.cc",
     "http/http_auth_gssapi_posix_unittest.cc",
     "http/http_auth_handler_basic_unittest.cc",
     "http/http_auth_handler_digest_unittest.cc",
     "http/http_auth_handler_factory_unittest.cc",
     "http/http_auth_handler_mock.cc",
     "http/http_auth_handler_mock.h",
     "http/http_auth_handler_negotiate_unittest.cc",
+    "http/http_auth_handler_ntlm_portable_unittest.cc",

[asanka, 2017/06/23 21:29:10]

inside the 'test("net_unittests")' definition, add a condition to remove this
source file when 'is_win' is true.

[zentaro, 2017/07/05 17:57:41]

Since I already added a condition for !is_win for the other test I add this
there rather than doing the inverse.

     "http/http_auth_handler_unittest.cc",
     "http/http_auth_multi_round_parse_unittest.cc",
     "http/http_auth_preferences_unittest.cc",
     "http/http_auth_sspi_win_unittest.cc",
     "http/http_auth_unittest.cc",
     "http/http_basic_state_unittest.cc",
     "http/http_byte_range_unittest.cc",
     "http/http_cache_lookup_manager_unittest.cc",
     "http/http_cache_unittest.cc",
     "http/http_chunked_decoder_unittest.cc",
@@ skipping 20 matching lines @@
     "http/mock_allow_http_auth_preferences.cc",
     "http/mock_allow_http_auth_preferences.h",
     "http/mock_gssapi_library_posix.cc",
     "http/mock_gssapi_library_posix.h",
     "http/mock_http_cache.cc",
     "http/mock_http_cache.h",
     "http/mock_sspi_library_win.cc",
     "http/mock_sspi_library_win.h",
     "http/ntlm_buffer_reader_unittest.cc",
     "http/ntlm_buffer_writer_unittest.cc",
+    "http/ntlm_client_unittest.cc",
     "http/transport_security_persister_unittest.cc",
     "http/transport_security_state_unittest.cc",
     "http/url_security_manager_unittest.cc",
     "http2/decoder/decode_buffer_test.cc",
     "http2/decoder/decode_http2_structures_test.cc",
     "http2/decoder/frame_decoder_state_test_util.cc",
     "http2/decoder/frame_decoder_state_test_util.h",
     "http2/decoder/http2_frame_decoder_listener_test_util.cc",
     "http2/decoder/http2_frame_decoder_listener_test_util.h",
     "http2/decoder/http2_frame_decoder_test.cc",
@@ skipping 1343 matching lines @@
   ]
   deps = [
     ":net_fuzzer_test_support",
     ":test_support",
     "//base",
     "//net",
   ]
   dict = "data/fuzzer_dictionaries/net_spdy_session_fuzzer.dict"
   seed_corpus = "data/fuzzer_data/net_spdy_session_fuzzer/"
 }