Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2873653002: [array] Don't adapt arguments for ArrayIndexOf and ArrayIncludes (Closed)

Created:
3 years, 7 months ago by jgruber
Modified:
3 years, 7 months ago
Reviewers:
danno, gsathya
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[array] Don't adapt arguments for ArrayIndexOf and ArrayIncludes Mechanical change to remove argument adaption from Array.p.indexOf and Array.p.includes when the actual arguments counts does not match the formal parameter count. BUG=v8:6369 Review-Url: https://codereview.chromium.org/2873653002 Cr-Commit-Position: refs/heads/master@{#45218} Committed: https://chromium.googlesource.com/v8/v8/+/7cce53586fa45725d3c29e068fb57ab95d067585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -20 lines) Patch
M src/builtins/builtins-array-gen.cc View 3 chunks +34 lines, -16 lines 0 comments Download
M src/builtins/builtins-definitions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
jgruber
PTAL - no significant changes in runtime unfortunately.
3 years, 7 months ago (2017-05-09 14:35:48 UTC) #4
danno
lgtm
3 years, 7 months ago (2017-05-09 17:39:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873653002/1
3 years, 7 months ago (2017-05-10 06:44:53 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 06:46:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7cce53586fa45725d3c29e068fb57ab95d0...

Powered by Google App Engine
This is Rietveld 408576698