Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2873613002: Move WebArrayBuffer* from web/ -> core/exported/. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebArrayBuffer* from web/ -> core/exported/. These classes have no other dependencies in web/, so are easy to move. BUG=712963 Review-Url: https://codereview.chromium.org/2873613002 Cr-Commit-Position: refs/heads/master@{#470357} Committed: https://chromium.googlesource.com/chromium/src/+/6b4562e3bb6ed5dd0f5b4fd8f291d9d6f9c0650b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -206 lines) Patch
M third_party/WebKit/Source/core/exported/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebArrayBuffer.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebArrayBufferConverter.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebArrayBufferView.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/web/WebArrayBuffer.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/Source/web/WebArrayBufferConverter.cpp View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/Source/web/WebArrayBufferView.cpp View 1 chunk +0 lines, -75 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
slangley
3 years, 7 months ago (2017-05-09 09:02:16 UTC) #2
haraken
LGTM
3 years, 7 months ago (2017-05-09 10:58:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873613002/1
3 years, 7 months ago (2017-05-09 12:18:31 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 17:04:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b4562e3bb6ed5dd0f5b4fd8f291...

Powered by Google App Engine
This is Rietveld 408576698