Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: cc/ipc/struct_traits_unittest.cc

Issue 2873593002: Force use of and cache render surface. (Closed)
Patch Set: Reduce unneeded code in surface aggregator and add more test. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/ipc/struct_traits_unittest.cc
diff --git a/cc/ipc/struct_traits_unittest.cc b/cc/ipc/struct_traits_unittest.cc
index 5bffa4584bcb68ed9aa17bd7ffe57cc545d49ccd..48fa5d7e12ba6644d2803b1a270afd2857bf24d2 100644
--- a/cc/ipc/struct_traits_unittest.cc
+++ b/cc/ipc/struct_traits_unittest.cc
@@ -831,10 +831,13 @@ TEST_F(StructTraitsTest, RenderPass) {
background_filters.Append(FilterOperation::CreateSaturateFilter(2.f));
gfx::ColorSpace color_space = gfx::ColorSpace::CreateXYZD50();
const bool has_transparent_background = true;
+ const bool should_cache_render_surface = false;
+ const bool has_damage_from_contributing_content = false;
std::unique_ptr<RenderPass> input = RenderPass::Create();
input->SetAll(render_pass_id, output_rect, damage_rect, transform_to_root,
filters, background_filters, color_space,
- has_transparent_background);
+ has_transparent_background, should_cache_render_surface,
+ has_damage_from_contributing_content);
SharedQuadState* shared_state_1 = input->CreateAndAppendSharedQuadState();
shared_state_1->SetAll(
@@ -949,10 +952,13 @@ TEST_F(StructTraitsTest, RenderPassWithEmptySharedQuadStateList) {
SkColorSpaceTransferFn fn = {1, 0, 1, 0, 0, 0, 1};
gfx::ColorSpace color_space = gfx::ColorSpace::CreateCustom(to_XYZD50, fn);
const bool has_transparent_background = true;
+ const bool should_cache_render_surface = false;
+ const bool has_damage_from_contributing_content = false;
std::unique_ptr<RenderPass> input = RenderPass::Create();
input->SetAll(render_pass_id, output_rect, damage_rect, transform_to_root,
FilterOperations(), FilterOperations(), color_space,
- has_transparent_background);
+ has_transparent_background, should_cache_render_surface,
+ has_damage_from_contributing_content);
// Unlike the previous test, don't add any quads to the list; we need to
// verify that the serialization code can deal with that.

Powered by Google App Engine
This is Rietveld 408576698