Small CSS improvements on the new Incognito NTP

Small CSS improvements on the new Incognito NTP

1. The rgb() colors expressing X% white are replaced with rgba() colors
   expressing 100% white with X% opacity. Since the background is not
   completely black (0% white), this makes the text color slightly lighter.

2. The 16px/24px vertical offsets are replaced with 1rem/1.5rem. This
   means no functional change for the default font size of 16px, but the
   paragraph spacing looks better for nondefault sizes.

BUG=693525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2873573003
Cr-Commit-Position: refs/heads/master@{#470543}
Committed: https://chromium.googlesource.com/chromium/src/+/4c61cbbb6d255c2a846deaf9e3979843c5756b1b

[msramek, 2017-05-09 13:19:31]

Description was changed from

==========
Small CSS improvements on the new Incognito NTP

1. The rgb() colors expressing X% white are replaced with rgba() colors
   expressing 100% white with X% opacity. Since the background is not
   completely black (0% white), this makes the text color slightly lighter.

2. The 16px/24px vertical offsets are replaced with 1rem/1.5rem. This
   means no functional change for the default font size of 16px, but the
   paragraph spacing looks better for nondefault sizes.

BUG=693525
==========

to

==========
Small CSS improvements on the new Incognito NTP

1. The rgb() colors expressing X% white are replaced with rgba() colors
   expressing 100% white with X% opacity. Since the background is not
   completely black (0% white), this makes the text color slightly lighter.

2. The 16px/24px vertical offsets are replaced with 1rem/1.5rem. This
   means no functional change for the default font size of 16px, but the
   paragraph spacing looks better for nondefault sizes.

BUG=693525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[msramek, 2017-05-09 13:24:53]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 13:25:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-05-09 14:26:18]

msramek@chromium.org changed reviewers:
+ dbeam@chromium.org

[msramek, 2017-05-09 14:26:20]

Hi Dan!

Can you please have a look? This should be a small and straightforward CL.

Thanks!
Martin

[commit-bot: I haz the power, 2017-05-09 14:44:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 14:44:53]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-05-09 19:08:38]

lgtm

https://codereview.chromium.org/2873573003/diff/1/chrome/browser/resources/nt...
File chrome/browser/resources/ntp4/md_incognito_tab.css (left):

https://codereview.chromium.org/2873573003/diff/1/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/md_incognito_tab.css:33: color: white;
what's the difference?

[msramek, 2017-05-09 19:43:46]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 19:45:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-05-09 19:45:43]

Thanks!

https://codereview.chromium.org/2873573003/diff/1/chrome/browser/resources/nt...
File chrome/browser/resources/ntp4/md_incognito_tab.css (left):

https://codereview.chromium.org/2873573003/diff/1/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/md_incognito_tab.css:33: color: white;
On 2017/05/09 19:08:38, Dan Beam wrote:
> what's the difference?

Heh, I guess I got overexcited with the replacements. Switched back to 'white'.

[msramek, 2017-05-09 19:46:23]

The CQ bit was unchecked by msramek@chromium.org

[msramek, 2017-05-09 19:46:30]

The CQ bit was checked by msramek@chromium.org

[msramek, 2017-05-09 19:46:31]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2873573003/#ps20001
(title: "Use a name for the named color.")

[commit-bot: I haz the power, 2017-05-09 19:46:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 01:56:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 01:56:57]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msramek, 2017-05-10 02:17:45]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2017-05-10 02:18:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 04:20:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 04:20:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[msramek, 2017-05-10 07:28:54]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2017-05-10 07:29:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 10:08:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 10:08:45]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msramek, 2017-05-10 10:14:03]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2017-05-10 10:14:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 12:49:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494411243905710,
"parent_rev": "fcd5fefabd15ceeddbfe313e6482fe000dddaf37", "commit_rev":
"4c61cbbb6d255c2a846deaf9e3979843c5756b1b"}

[commit-bot: I haz the power, 2017-05-10 12:49:47]

Description was changed from

==========
Small CSS improvements on the new Incognito NTP

1. The rgb() colors expressing X% white are replaced with rgba() colors
   expressing 100% white with X% opacity. Since the background is not
   completely black (0% white), this makes the text color slightly lighter.

2. The 16px/24px vertical offsets are replaced with 1rem/1.5rem. This
   means no functional change for the default font size of 16px, but the
   paragraph spacing looks better for nondefault sizes.

BUG=693525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Small CSS improvements on the new Incognito NTP

1. The rgb() colors expressing X% white are replaced with rgba() colors
   expressing 100% white with X% opacity. Since the background is not
   completely black (0% white), this makes the text color slightly lighter.

2. The 16px/24px vertical offsets are replaced with 1rem/1.5rem. This
   means no functional change for the default font size of 16px, but the
   paragraph spacing looks better for nondefault sizes.

BUG=693525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2873573003
Cr-Commit-Position: refs/heads/master@{#470543}
Committed:
https://chromium.googlesource.com/chromium/src/+/4c61cbbb6d255c2a846deaf9e397...
==========

[commit-bot: I haz the power, 2017-05-10 12:49:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4c61cbbb6d255c2a846deaf9e397...