Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2873563002:
MD History: Prevent focus ring when clicking on 'Clear Browsing Data' (Closed)
|
Created:
3 years, 7 months ago by tsergeant Modified:
3 years, 7 months ago Reviewers:
calamity CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD History: Prevent focus ring when clicking on 'Clear Browsing Data'
Setting tabindex="" on this link restores the default <a> behavior,
which shows a focus ring on keyboard focus but not on click.
BUG=714515
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2873563002
Cr-Commit-Position: refs/heads/master@{#470453}
Committed: https://chromium.googlesource.com/chromium/src/+/8e4017253ecba8c9745dff3b363b63e4781cd4ef
Patch Set 1 #
Messages
Total messages: 18 (14 generated)
Description was changed from ========== MD History: Prevent focus ring when clicking on 'Clear Browsing Data' Setting tabindex="" on this link restores the default <a> behavior, which shows a focus ring on keyboard focus but not on click. BUG=714515 ========== to ========== MD History: Prevent focus ring when clicking on 'Clear Browsing Data' Setting tabindex="" on this link restores the default <a> behavior, which shows a focus ring on keyboard focus but not on click. BUG=714515 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run
tsergeant@chromium.org changed reviewers: + calamity@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by tsergeant@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494384876190400, "parent_rev":
"67711f360e46533642ae711d9cdf868fb7a64215", "commit_rev":
"411249c83830939bc5d752d9fc3e8b756a454633"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494384876190400, "parent_rev":
"ff0919b6b5e43b9a604bfdc98492a26430b14b1a", "commit_rev":
"8e4017253ecba8c9745dff3b363b63e4781cd4ef"}
Message was sent while issue was closed.
Description was changed from ========== MD History: Prevent focus ring when clicking on 'Clear Browsing Data' Setting tabindex="" on this link restores the default <a> behavior, which shows a focus ring on keyboard focus but not on click. BUG=714515 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD History: Prevent focus ring when clicking on 'Clear Browsing Data' Setting tabindex="" on this link restores the default <a> behavior, which shows a focus ring on keyboard focus but not on click. BUG=714515 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2873563002 Cr-Commit-Position: refs/heads/master@{#470453} Committed: https://chromium.googlesource.com/chromium/src/+/8e4017253ecba8c9745dff3b363b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8e4017253ecba8c9745dff3b363b... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
