Create individual cells for MostVisited tiles

Create individual cells for MostVisited tiles

This CL displays the MostVisited tiles as individual cells instead of using
one big cell and fitting all of them inside.
This allows easier interactions with the user and easier animations on rotation.
The layout is yet to be done.

BUG=707754
Review-Url: https://codereview.chromium.org/2873503005
Cr-Commit-Position: refs/heads/master@{#470512}
Committed: https://chromium.googlesource.com/chromium/src/+/39c34e94e02aa327f7f08b888f1d0949cb940a9c

[gambard, 2017-05-09 08:45:47]

gambard@chromium.org changed reviewers:
+ lpromero@chromium.org

[gambard, 2017-05-09 08:45:48]

PTAL.

[gambard, 2017-05-09 08:51:42]

gambard@chromium.org changed reviewers:
+ jif@chromium.org

[gambard, 2017-05-09 08:51:42]

jif: PTAL as lpromero is OOO.

[jif, 2017-05-09 15:28:58]

lgtm

https://codereview.chromium.org/2873503005/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.h
(right):

https://codereview.chromium.org/2873503005/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.h:38:
+ (CGSize)defaultSize;
are you planning on using this later?

https://codereview.chromium.org/2873503005/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm
(right):

https://codereview.chromium.org/2873503005/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm:19:
const CGFloat kFaviconSize = 48;
optional: consider doing
const CGSize kFaviconSize = {48, 48};

https://codereview.chromium.org/2873503005/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm:22:
// Size of the tile.
I think this comment is incorrect.

https://codereview.chromium.org/2873503005/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm:23:
const CGFloat kWidth = 73;
How about:
const CGSize kCellSize = {73, 100};

[gambard, 2017-05-09 16:27:35]

Thanks!

https://codereview.chromium.org/2873503005/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.h
(right):

https://codereview.chromium.org/2873503005/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.h:38:
+ (CGSize)defaultSize;
On 2017/05/09 15:28:58, jif wrote:
> are you planning on using this later?

Yes, I will be using it in the UICollectionViewDelegateFlowLayout to have the
size of the items.

https://codereview.chromium.org/2873503005/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm
(right):

https://codereview.chromium.org/2873503005/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm:19:
const CGFloat kFaviconSize = 48;
On 2017/05/09 15:28:58, jif wrote:
> optional: consider doing
> const CGSize kFaviconSize = {48, 48};

It is used only in one constraint as width (the height is set to be the same as
the width), so I prefer to keep it as one CGFloat.

https://codereview.chromium.org/2873503005/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm:22:
// Size of the tile.
On 2017/05/09 15:28:58, jif wrote:
> I think this comment is incorrect.

It is correct: a cell represent a Most Visited tile so tile = cell in this
context.
But I agree it is unclear, I have updated it.

https://codereview.chromium.org/2873503005/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm:23:
const CGFloat kWidth = 73;
On 2017/05/09 15:28:58, jif wrote:
> How about:
> const CGSize kCellSize = {73, 100};

Done.

[gambard, 2017-05-09 16:27:48]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-05-09 16:27:48]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org
Link to the patchset: https://codereview.chromium.org/2873503005/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2017-05-09 16:28:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 18:06:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 18:06:13]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gambard, 2017-05-10 06:30:00]

The CQ bit was checked by gambard@chromium.org

[commit-bot: I haz the power, 2017-05-10 06:30:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 07:23:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494397800812860,
"parent_rev": "399218194335c41bdb975bff6a7aac99d4dd6b0c", "commit_rev":
"39c34e94e02aa327f7f08b888f1d0949cb940a9c"}

[commit-bot: I haz the power, 2017-05-10 07:23:29]

Description was changed from

==========
Create individual cells for MostVisited tiles

This CL displays the MostVisited tiles as individual cells instead of using
one big cell and fitting all of them inside.
This allows easier interactions with the user and easier animations on rotation.
The layout is yet to be done.

BUG=707754
==========

to

==========
Create individual cells for MostVisited tiles

This CL displays the MostVisited tiles as individual cells instead of using
one big cell and fitting all of them inside.
This allows easier interactions with the user and easier animations on rotation.
The layout is yet to be done.

BUG=707754

Review-Url: https://codereview.chromium.org/2873503005
Cr-Commit-Position: refs/heads/master@{#470512}
Committed:
https://chromium.googlesource.com/chromium/src/+/39c34e94e02aa327f7f08b888f1d...
==========

[commit-bot: I haz the power, 2017-05-10 07:23:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/39c34e94e02aa327f7f08b888f1d...