third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp - Issue 2873493004: [Media Controls] Prevent flicker when enter/exit fullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp

Issue 2873493004: [Media Controls] Prevent flicker when enter/exit fullscreen (Closed)

Patch Set: Use test-25fps.mp4 instead of counting.mp4 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/media/controls/video-enter-exit-fullscreen-while-hovering-shows-controls.html ('K') | « third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp

diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp b/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp

index cfa659acbbe81280b54c98b2203cc101bc00db95..2c0729d20329dd4e57d0089e1c257bf9e5e66fee 100644

--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp

+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp

@@ -259,7 +259,7 @@ TEST_F(MediaControlsImplTest, HideAndShow) {

ASSERT_TRUE(IsElementVisible(*panel));

MediaControls().Hide();

ASSERT_FALSE(IsElementVisible(*panel));

- MediaControls().Show();

+ MediaControls().MaybeShow();

ASSERT_TRUE(IsElementVisible(*panel));

}

@@ -398,7 +398,7 @@ TEST_F(MediaControlsImplTest, KeepControlsVisibleIfOverflowListVisible) {

MediaControls().MediaElement().Play();

testing::RunPendingTasks();

- MediaControls().Show();

+ MediaControls().MaybeShow();

MediaControls().ToggleOverflowMenu();

EXPECT_TRUE(IsElementVisible(*overflow_list));