[Media Controls] Prevent flicker when enter/exit fullscreen

third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/media_controls/MediaControlsImpl.h"
 
 #include <limits>
 #include <memory>
 #include "core/HTMLNames.h"
 #include "core/css/StylePropertySet.h"
@@ skipping 241 matching lines @@
   MediaControls().MediaElement().SetBooleanAttribute(HTMLNames::controlsAttr,
                                                      true);
 
   Element* panel = GetElementByShadowPseudoId(MediaControls(),
                                               "-webkit-media-controls-panel");
   ASSERT_NE(nullptr, panel);
 
   ASSERT_TRUE(IsElementVisible(*panel));
   MediaControls().Hide();
   ASSERT_FALSE(IsElementVisible(*panel));
-  MediaControls().Show();
+  MediaControls().MaybeShow();
   ASSERT_TRUE(IsElementVisible(*panel));
 }
 
 TEST_F(MediaControlsImplTest, Reset) {
   MediaControls().MediaElement().SetBooleanAttribute(HTMLNames::controlsAttr,
                                                      true);
 
   Element* panel = GetElementByShadowPseudoId(MediaControls(),
                                               "-webkit-media-controls-panel");
   ASSERT_NE(nullptr, panel);
@@ skipping 118 matching lines @@
   ASSERT_NE(nullptr, overflow_list);
 
   Element* panel = GetElementByShadowPseudoId(MediaControls(),
                                               "-webkit-media-controls-panel");
   ASSERT_NE(nullptr, panel);
 
   MediaControls().MediaElement().SetSrc("http://example.com");
   MediaControls().MediaElement().Play();
   testing::RunPendingTasks();
 
-  MediaControls().Show();
+  MediaControls().MaybeShow();
   MediaControls().ToggleOverflowMenu();
   EXPECT_TRUE(IsElementVisible(*overflow_list));
 
   SimulateHideMediaControlsTimerFired();
   EXPECT_TRUE(IsElementVisible(*overflow_list));
   EXPECT_TRUE(IsElementVisible(*panel));
 }
 
 TEST_F(MediaControlsImplTest, DownloadButtonDisplayed) {
   EnsureSizing();
@@ skipping 472 matching lines @@
   {
     Persistent<HTMLMediaElement> video_holder = element;
     page_holder->GetDocument().body()->RemoveChild(element);
     page_holder->GetDocument().body()->AppendChild(video_holder.Get());
     EXPECT_TRUE(remote_playback->HasEventListeners());
     EXPECT_TRUE(HasAvailabilityCallbacks(remote_playback));
   }
 }
 
 }  // namespace blink