cros: Update ash when prefs related to lock are changed

cros: Update ash when prefs related to lock are changed

BUG=670423
TEST=SessionControllerClientTest.UserPrefsChange

Review-Url: https://codereview.chromium.org/2873453003
Cr-Commit-Position: refs/heads/master@{#470368}
Committed: https://chromium.googlesource.com/chromium/src/+/33f44a4a580cff9bbfc7f2125f33602f5bbb99c5

[xiyuan, 2017-05-08 20:46:28]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 20:47:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2017-05-08 20:47:15]

xiyuan@chromium.org changed reviewers:
+ jamescook@chromium.org

[commit-bot: I haz the power, 2017-05-08 21:30:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 21:30:02]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-05-08 21:50:00]

LGTM with nits

https://codereview.chromium.org/2873453003/diff/1/chrome/browser/ui/ash/sessi...
File chrome/browser/ui/ash/session_controller_client.h (right):

https://codereview.chromium.org/2873453003/diff/1/chrome/browser/ui/ash/sessi...
chrome/browser/ui/ash/session_controller_client.h:137:
std::vector<std::unique_ptr<PrefChangeRegistrar>> pref_change_registrars_;
nit: Comment that there is one per user. (And maybe that there is no particular
order, in particular that the order may not match the user session order.)

https://codereview.chromium.org/2873453003/diff/1/chrome/browser/ui/ash/sessi...
File chrome/browser/ui/ash/session_controller_client_unittest.cc (right):

https://codereview.chromium.org/2873453003/diff/1/chrome/browser/ui/ash/sessi...
chrome/browser/ui/ash/session_controller_client_unittest.cc:203: // Calls
private methods to create a testing profile.
nit: Maybe note that the profile is owned by the ProfileManager (is it?).

[xiyuan, 2017-05-08 22:27:39]

https://codereview.chromium.org/2873453003/diff/1/chrome/browser/ui/ash/sessi...
File chrome/browser/ui/ash/session_controller_client.h (right):

https://codereview.chromium.org/2873453003/diff/1/chrome/browser/ui/ash/sessi...
chrome/browser/ui/ash/session_controller_client.h:137:
std::vector<std::unique_ptr<PrefChangeRegistrar>> pref_change_registrars_;
On 2017/05/08 21:49:59, James Cook (sheriff - slow) wrote:
> nit: Comment that there is one per user. (And maybe that there is no
particular
> order, in particular that the order may not match the user session order.)

Done.

https://codereview.chromium.org/2873453003/diff/1/chrome/browser/ui/ash/sessi...
File chrome/browser/ui/ash/session_controller_client_unittest.cc (right):

https://codereview.chromium.org/2873453003/diff/1/chrome/browser/ui/ash/sessi...
chrome/browser/ui/ash/session_controller_client_unittest.cc:203: // Calls
private methods to create a testing profile.
On 2017/05/08 21:50:00, James Cook (sheriff - slow) wrote:
> nit: Maybe note that the profile is owned by the ProfileManager (is it?).

Done. 

It is sort of owned by ProfileManager. ProfileManager owns ProfilesInfoMap,
which has a linked_ptr<ProfileInfo>, and ProfileInfo owns Profile. The
linked_ptr part is tricky and Profile is released on the last ref of
linked_ptr<ProfileInfo> is gone. This usually happens when destructing
ProfileManager on shutdown.

[xiyuan, 2017-05-08 22:28:16]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2017-05-08 22:28:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2873453003/#ps20001
(title: "fix nits")

[commit-bot: I haz the power, 2017-05-08 22:30:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 23:27:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 23:28:01]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[xiyuan, 2017-05-09 15:31:01]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2017-05-09 15:31:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 17:35:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494343861981080,
"parent_rev": "777cb457cb9989f53d135239d36196a41835b6a9", "commit_rev":
"33f44a4a580cff9bbfc7f2125f33602f5bbb99c5"}

[commit-bot: I haz the power, 2017-05-09 17:36:08]

Description was changed from

==========
cros: Update ash when prefs related to lock are changed

BUG=670423
TEST=SessionControllerClientTest.UserPrefsChange
==========

to

==========
cros: Update ash when prefs related to lock are changed

BUG=670423
TEST=SessionControllerClientTest.UserPrefsChange

Review-Url: https://codereview.chromium.org/2873453003
Cr-Commit-Position: refs/heads/master@{#470368}
Committed:
https://chromium.googlesource.com/chromium/src/+/33f44a4a580cff9bbfc7f2125f33...
==========

[commit-bot: I haz the power, 2017-05-09 17:36:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/33f44a4a580cff9bbfc7f2125f33...