Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2873383002: Remove unused instant support for chrome://large-icon and chrome://fallback-icon (Closed)

Created:
3 years, 7 months ago by pkotwicz
Modified:
3 years, 7 months ago
Reviewers:
Marc Treib, Lei Zhang
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, jered+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, jkrcal
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused instant support for chrome://large-icon and chrome://fallback-icon BUG=None Review-Url: https://codereview.chromium.org/2873383002 Cr-Commit-Position: refs/heads/master@{#471882} Committed: https://chromium.googlesource.com/chromium/src/+/b2707b25a2148bf1e510d1847c66932d10e60174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -96 lines) Patch
M chrome/browser/search/instant_service.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_unittest.cc View 5 chunks +0 lines, -58 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
pkotwicz
treib@ can you please take a look? I will delete support for chrome://fallback-icon (and non ...
3 years, 7 months ago (2017-05-10 17:46:41 UTC) #2
Marc Treib
LGTM, thanks!
3 years, 7 months ago (2017-05-11 08:05:57 UTC) #3
pkotwicz
thestig@ for chrome/renderer/ OWNERS
3 years, 7 months ago (2017-05-12 07:25:10 UTC) #5
Lei Zhang
lgtm
3 years, 7 months ago (2017-05-15 18:12:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873383002/1
3 years, 7 months ago (2017-05-15 18:40:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b2707b25a2148bf1e510d1847c66932d10e60174
3 years, 7 months ago (2017-05-15 20:22:10 UTC) #12
kolos1
3 years, 7 months ago (2017-05-18 12:05:57 UTC) #13
Message was sent while issue was closed.
Hi Peter,

I am afraid the password page (chrome://settings/passwords) needs this service.
We need to add icons to the page and would like to use new functionality of
LargeIcon service (crbug.com/644102), namely, fetching icons missed in the cache
via Google Server.

Regards,
Maxim

Powered by Google App Engine
This is Rietveld 408576698