[subresource_filter] Gate Page Info on activation (i.e. website setting)

chrome/browser/ui/page_info/page_info_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/page_info/page_info.h"
 
 #include <string>
 #include <vector>
 
 #include "base/at_exit.h"
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
+#include "base/test/scoped_feature_list.h"
 #include "build/build_config.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/ui/page_info/page_info_ui.h"
 #include "chrome/browser/usb/usb_chooser_context.h"
 #include "chrome/browser/usb/usb_chooser_context_factory.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/content_settings/core/common/content_settings.h"
 #include "components/content_settings/core/common/content_settings_types.h"
 #include "components/infobars/core/infobar.h"
+#include "components/subresource_filter/core/browser/subresource_filter_features.h"
 #include "content/public/browser/ssl_status.h"
+#include "content/public/common/content_switches.h"
 #include "device/base/mock_device_client.h"
 #include "device/usb/mock_usb_device.h"
 #include "device/usb/mock_usb_service.h"
 #include "net/cert/cert_status_flags.h"
 #include "net/cert/x509_certificate.h"
 #include "net/ssl/ssl_connection_status_flags.h"
 #include "net/test/cert_test_util.h"
 #include "net/test/test_certificate_data.h"
 #include "net/test/test_data_directory.h"
 #include "ppapi/features/features.h"
@@ skipping 67 matching lines @@
 
     // Create the certificate.
     cert_ =
         net::ImportCertFromFile(net::GetTestCertsDirectory(), "ok_cert.pem");
     ASSERT_TRUE(cert_);
 
     TabSpecificContentSettings::CreateForWebContents(web_contents());
     InfoBarService::CreateForWebContents(web_contents());
 
     // Setup mock ui.
-    mock_ui_.reset(new MockPageInfoUI());
-    // Use this rather than gmock's ON_CALL.WillByDefault(Invoke(... because
-    // gmock doesn't handle move-only types well.
-    mock_ui_->set_permission_info_callback_ =
-        base::Bind(&PageInfoTest::SetPermissionInfo, base::Unretained(this));
+    ResetMockUI();
   }
 
   void TearDown() override {
     ASSERT_TRUE(page_info_.get()) << "No PageInfo instance created.";
     RenderViewHostTestHarness::TearDown();
     page_info_.reset();
   }
 
   void SetDefaultUIExpectations(MockPageInfoUI* mock_ui) {
     // During creation |PageInfo| makes the following calls to the ui.
     EXPECT_CALL(*mock_ui, SetPermissionInfoStub());
     EXPECT_CALL(*mock_ui, SetIdentityInfo(_));
     EXPECT_CALL(*mock_ui, SetCookieInfo(_));
   }
 
   void SetURL(const std::string& url) { url_ = GURL(url); }
 
   void SetPermissionInfo(const PermissionInfoList& permission_info_list,
                          ChosenObjectInfoList chosen_object_info_list) {
     last_chosen_object_info_.clear();
     for (auto& chosen_object_info : chosen_object_info_list)
       last_chosen_object_info_.push_back(std::move(chosen_object_info));
+    last_permission_info_list_ = permission_info_list;
   }
 
-  void ResetMockUI() { mock_ui_.reset(new MockPageInfoUI()); }
+  void ResetMockUI() {
+    mock_ui_.reset(new MockPageInfoUI());
+    // Use this rather than gmock's ON_CALL.WillByDefault(Invoke(... because
+    // gmock doesn't handle move-only types well.
+    mock_ui_->set_permission_info_callback_ =
+        base::Bind(&PageInfoTest::SetPermissionInfo, base::Unretained(this));
+  }
+
 
   void ClearPageInfo() { page_info_.reset(nullptr); }
 
   const GURL& url() const { return url_; }
   scoped_refptr<net::X509Certificate> cert() { return cert_; }
   MockPageInfoUI* mock_ui() { return mock_ui_.get(); }
   const security_state::SecurityInfo& security_info() { return security_info_; }
   const std::vector<std::unique_ptr<PageInfoUI::ChosenObjectInfo>>&
   last_chosen_object_info() {
     return last_chosen_object_info_;
   }
+  const PermissionInfoList& last_permission_info_list() {
+    return last_permission_info_list_;
+  }
   TabSpecificContentSettings* tab_specific_content_settings() {
     return TabSpecificContentSettings::FromWebContents(web_contents());
   }
   InfoBarService* infobar_service() {
     return InfoBarService::FromWebContents(web_contents());
   }
 
   PageInfo* page_info() {
     if (!page_info_.get()) {
       page_info_.reset(new PageInfo(mock_ui(), profile(),
@@ skipping 10 matching lines @@
   security_state::SecurityInfo security_info_;
 
  private:
   device::MockDeviceClient device_client_;
   std::unique_ptr<PageInfo> page_info_;
   std::unique_ptr<MockPageInfoUI> mock_ui_;
   scoped_refptr<net::X509Certificate> cert_;
   GURL url_;
   std::vector<std::unique_ptr<PageInfoUI::ChosenObjectInfo>>
       last_chosen_object_info_;
+  PermissionInfoList last_permission_info_list_;
 };
 
 }  // namespace
 
 TEST_F(PageInfoTest, OnPermissionsChanged) {
   // Setup site permissions.
   HostContentSettingsMap* content_settings =
       HostContentSettingsMapFactory::GetForProfile(profile());
   ContentSetting setting = content_settings->GetContentSetting(
       url(), url(), CONTENT_SETTINGS_TYPE_POPUPS, std::string());
@@ skipping 552 matching lines @@
     // call, so it is called twice in total.
     histograms.ExpectTotalCount(kGenericHistogram, 2);
     histograms.ExpectBucketCount(kGenericHistogram,
                                  PageInfo::PageInfoAction::PAGE_INFO_OPENED, 2);
 
     histograms.ExpectTotalCount(test.histogram_name, 2);
     histograms.ExpectBucketCount(test.histogram_name,
                                  PageInfo::PageInfoAction::PAGE_INFO_OPENED, 2);
   }
 }
+
+// Tests that the SubresourceFilter setting is omitted correctly.
+TEST_F(PageInfoTest, SubresourceFilterSetting_MatchesActivation) {
+  base::test::ScopedFeatureList feature_list;
+  feature_list.InitAndEnableFeature(
+      subresource_filter::kSafeBrowsingSubresourceFilterExperimentalUI);
+  auto showing_setting = [](const PermissionInfoList& permissions) {
+    for (const auto& permission : permissions) {
+      if (permission.type == CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER)
+        return true;
+    }
+    return false;
+  };
+
+  // By default, the setting should not appear at all.
+  SetURL("https://example.test/");
+  SetDefaultUIExpectations(mock_ui());
+  page_info();
+  EXPECT_FALSE(showing_setting(last_permission_info_list()));
+
+  // Reset state.
+  ResetMockUI();
+  ClearPageInfo();
+  SetDefaultUIExpectations(mock_ui());
+
+  // Now, simulate activation on that origin, which is encoded by the existence
+  // of the website setting. The setting should then appear in page_info.
+  HostContentSettingsMap* content_settings =
+      HostContentSettingsMapFactory::GetForProfile(profile());
+  content_settings->SetWebsiteSettingDefaultScope(
+      url(), GURL(), CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER_DATA,
+      std::string(), base::MakeUnique<base::DictionaryValue>());
+  page_info();
+  EXPECT_TRUE(showing_setting(last_permission_info_list()));
+}