[subresource_filter] Gate Page Info on activation (i.e. website setting)

[subresource_filter] Gate Page Info on activation (i.e. website setting)

This setting should only show up if there is cached site activation,
which is determined via querying the associated website setting. 

BUG=689487
Review-Url: https://codereview.chromium.org/2873313002
Cr-Commit-Position: refs/heads/master@{#470988}
Committed: https://chromium.googlesource.com/chromium/src/+/ad1eaa6c4fd1c53f6e4be4da087a8c13a1e84058

[Charlie Harrison, 2017-05-10 14:42:47]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 14:43:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-05-10 14:44:43]

Description was changed from

==========
[subresource_filter] Gate Page Info on activation (i.e. website setting)

BUG=689487
==========

to

==========
[subresource_filter] Gate Page Info on activation (i.e. website setting)

This setting should only show up if there is cached site activation,
which is determined via querying the associated website setting. 

BUG=689487
==========

[commit-bot: I haz the power, 2017-05-10 14:47:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 14:47:43]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Charlie Harrison, 2017-05-10 14:49:56]

csharrison@chromium.org changed reviewers:
+ raymes@chromium.org

[Charlie Harrison, 2017-05-10 14:49:56]

raymes: PTAL? At some point we should also have a more integration-y test for
this but for now having:
1. Tests that assert Page Info setting is gated on website setting
2. Integration tests querying the website setting (in dependent CL)

Seems like reasonable coverage. In the future I could see adding something like
the mock_page_info_ui to our integration unit test suite
subresource_filter_unittests.

Please excuse the patch failures. This is a big chain of CLs so it is difficult
to keep everything sync'd up.

[raymes, 2017-05-10 23:53:51]

lgtm

https://codereview.chromium.org/2873313002/diff/1/chrome/browser/ui/page_info...
File chrome/browser/ui/page_info/page_info.cc (right):

https://codereview.chromium.org/2873313002/diff/1/chrome/browser/ui/page_info...
chrome/browser/ui/page_info/page_info.cc:128:
subresource_filter::kSafeBrowsingSubresourceFilterExperimentalUI))
nit: {}

[Charlie Harrison, 2017-05-11 14:10:48]

Thanks!

cc shivanisha FYI

https://codereview.chromium.org/2873313002/diff/1/chrome/browser/ui/page_info...
File chrome/browser/ui/page_info/page_info.cc (right):

https://codereview.chromium.org/2873313002/diff/1/chrome/browser/ui/page_info...
chrome/browser/ui/page_info/page_info.cc:128:
subresource_filter::kSafeBrowsingSubresourceFilterExperimentalUI))
On 2017/05/10 23:53:51, raymes wrote:
> nit: {}

Done.

[shivanisha, 2017-05-11 14:38:25]

On 2017/05/11 at 14:10:48, csharrison wrote:
> Thanks!
> 
> cc shivanisha FYI
> 
>
https://codereview.chromium.org/2873313002/diff/1/chrome/browser/ui/page_info...
> File chrome/browser/ui/page_info/page_info.cc (right):
> 
>
https://codereview.chromium.org/2873313002/diff/1/chrome/browser/ui/page_info...
> chrome/browser/ui/page_info/page_info.cc:128:
subresource_filter::kSafeBrowsingSubresourceFilterExperimentalUI))
> On 2017/05/10 23:53:51, raymes wrote:
> > nit: {}
> 
> Done.

Acknowledged. Thanks.

[Charlie Harrison, 2017-05-11 15:44:23]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2017-05-11 15:44:24]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2873313002/#ps20001
(title: "add {}")

[commit-bot: I haz the power, 2017-05-11 15:45:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 17:14:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494517463722970,
"parent_rev": "310fa98b9861be3c4b87fd8fd9d925dc83268bc3", "commit_rev":
"ad1eaa6c4fd1c53f6e4be4da087a8c13a1e84058"}

[commit-bot: I haz the power, 2017-05-11 17:14:53]

Description was changed from

==========
[subresource_filter] Gate Page Info on activation (i.e. website setting)

This setting should only show up if there is cached site activation,
which is determined via querying the associated website setting. 

BUG=689487
==========

to

==========
[subresource_filter] Gate Page Info on activation (i.e. website setting)

This setting should only show up if there is cached site activation,
which is determined via querying the associated website setting. 

BUG=689487

Review-Url: https://codereview.chromium.org/2873313002
Cr-Commit-Position: refs/heads/master@{#470988}
Committed:
https://chromium.googlesource.com/chromium/src/+/ad1eaa6c4fd1c53f6e4be4da087a...
==========

[commit-bot: I haz the power, 2017-05-11 17:14:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ad1eaa6c4fd1c53f6e4be4da087a...